Skip to content

docs: record proof-envelope trailing-byte strictness as canonical - #820

Merged
QuantumExplorer merged 1 commit into
developfrom
docs/audit-non-issue-trailing-bytes
Aug 21, 2026
Merged

docs: record proof-envelope trailing-byte strictness as canonical#820
QuantumExplorer merged 1 commit into
developfrom
docs/audit-non-issue-trailing-bytes

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • Add an audit-non-issues.md entry recording that strict trailing-byte rejection in the proof envelope is already merged (PR feat: add Element::ProvableSumTree + AggregateSumOnRange query #661) and is the shipped GROVE_V3 verifier behavior — there was never a lenient v3 verifier in production.
  • Rejects the PR fix(proofs): version trailing-byte proof decoding #739 gating shape ("legacy versions accept, new versions reject") so it is not re-proposed: grovedb v4.1.0 (last lenient release) does not contain GROVE_V3, and every platform v4.0.0 build from beta.1 (2026-06-02) onward pins a strict-decode grovedb rev (v4.0.0 → grovedb v5.0.0, v4.1.1 → v5.0.1). Re-gating leniency onto v1/v2/v3 now would loosen live verifiers and create the very intra-version divergence a gate exists to prevent.

Verification

  • Empirical check on clean develop: valid proof + one trailing byte is rejected with CorruptedData("...trailing bytes...") under every grove version v1–v4.
  • All 10 existing trailing_bytes regression tests pass (cargo test -p grovedb --lib trailing_bytes: 10 passed, 0 failed).
  • Docs-only change; no code touched, no V0 proof path involved.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added an audit entry documenting canonical rejection of trailing bytes in proof envelopes.
    • Recorded affected verification paths, regression coverage, historical version behavior, and conditions that could reopen the issue.

…oses out PR #739)

Adversarial re-triage of PR #739 for the GROVE_V4 boundary showed the
version-gating premise is false: grovedb v4.1.0 (the last lenient
release) does not contain GROVE_V3, and every platform v4.0.0 build
from beta.1 onward pins a strict-decode grovedb rev, so strict
trailing-byte rejection has been the live v3 verifier behavior since
the first v3 block. Record both the already-fixed malleability claim
and the rejected gating proposal in audit-non-issues so neither is
re-filed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: be6e1f0e-f1de-453b-ab85-0061b3c05378

📥 Commits

Reviewing files that changed from the base of the PR and between 1ec9a9e and c58f0a2.

📒 Files selected for processing (1)
  • docs/audit-non-issues.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds an audit entry that documents canonical trailing-byte rejection for proof envelopes. It records verifier coverage, historical GROVE behavior, and conditions for reconsideration.

Changes

Proof-envelope audit

Layer / File(s) Summary
Canonical trailing-byte rejection audit
docs/audit-non-issues.md
Documents strict decoding across verifier paths and payload versions. Records the historical GROVE deployment behavior and conditions that could make the issue valid again.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c58f0

This is a localized documentation-only change with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the documentation change that records proof-envelope trailing-byte strictness as canonical.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/audit-non-issue-trailing-bytes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@QuantumExplorer
QuantumExplorer merged commit c8f870f into develop Aug 21, 2026
5 of 6 checks passed
@QuantumExplorer
QuantumExplorer deleted the docs/audit-non-issue-trailing-bytes branch August 21, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant