docs: record proof-envelope trailing-byte strictness as canonical - #820
Conversation
…oses out PR #739) Adversarial re-triage of PR #739 for the GROVE_V4 boundary showed the version-gating premise is false: grovedb v4.1.0 (the last lenient release) does not contain GROVE_V3, and every platform v4.0.0 build from beta.1 onward pins a strict-decode grovedb rev, so strict trailing-byte rejection has been the live v3 verifier behavior since the first v3 block. Record both the already-fixed malleability claim and the rejected gating proposal in audit-non-issues so neither is re-filed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR adds an audit entry that documents canonical trailing-byte rejection for proof envelopes. It records verifier coverage, historical GROVE behavior, and conditions for reconsideration. ChangesProof-envelope audit
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized documentation-only change with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
audit-non-issues.mdentry recording that strict trailing-byte rejection in the proof envelope is already merged (PR feat: add Element::ProvableSumTree + AggregateSumOnRange query #661) and is the shipped GROVE_V3 verifier behavior — there was never a lenient v3 verifier in production.Verification
CorruptedData("...trailing bytes...")under every grove version v1–v4.trailing_bytesregression tests pass (cargo test -p grovedb --lib trailing_bytes: 10 passed, 0 failed).🤖 Generated with Claude Code
Summary by CodeRabbit