feat: bidirectional references - #104
Closed
iammadab wants to merge 190 commits into
Closed
Conversation
* test range from proof * add unbounded right * test for range to proof * add left unbounded * add absence tuple checks to test * test range to inclusive * test for range after proof * test for range after proof * test for range after to inclusive * test for range full proof * update verify proof func to account for unbounded ranges * add verification check for right non inclusive ranges * refactor bounds to return options * update verify function to work with range_after_* queries * fix range_after_proof test * fix range_after_to_proof test * fix range_after_to_proof_inclusive test * fix range_full_proof
iammadab
marked this pull request as ready for review
May 9, 2022 09:39
fominok
approved these changes
May 11, 2022
5 tasks
Contributor
|
closing this in favor of #345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
referenced items should keep track of all elements that reference them
this allows efficient updates to the references when the base item changes (updated or deleted)
When a base item gets deleted all its references should also get deleted.
When a reference gets deleted, the base item should stop pointing to it.