Skip to content

feat: restore wallet helpers as a first-class operation type - #79

Draft
thephez wants to merge 3 commits into
dashpay:masterfrom
thephez:feat/add-wallet-ops
Draft

feat: restore wallet helpers as a first-class operation type#79
thephez wants to merge 3 commits into
dashpay:masterfrom
thephez:feat/add-wallet-ops

Conversation

@thephez

@thephez thephez commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Reintroduce the Wallet operation type dropped in the Evo SDK rewrite (4ce19f5), now backed by the package-level wallet namespace. Phase 1 adds ten key-generation/utility operations: generate/validate mnemonic, mnemonic to seed, generate key pair(s), key pair from WIF/hex, pubkey to address, validate address, and sign message.

Wallet operations run locally in wasm and never touch the platform: executeSelected() skips ensureClient() for the wallet type, and network-dependent operations read the new getSelectedNetwork() helper (unifying the previously inconsistent radio fallbacks on mainnet).

The type extractor learns namespace-function declaration modules and package-level sdk_examples; docs render wallet as wallet.method with a local-execution note. A new preserveWhitespace flag keeps the sign-message text and BIP39 passphrase untrimmed, since whitespace there is significant.

Tests: wallet dispatch unit suite, getSelectedNetwork() coverage, namespace-function extractor fixtures, and an e2e suite with deterministic fixtures plus an offline guarantee asserting zero external requests.

Reintroduce the Wallet operation type dropped in the Evo SDK rewrite (4ce19f5), now backed by the package-level `wallet` namespace. Phase 1 adds ten key-generation/utility operations: generate/validate mnemonic, mnemonic to seed, generate key pair(s), key pair from WIF/hex, pubkey to address, validate address, and sign message.

Wallet operations run locally in wasm and never touch the platform: executeSelected() skips ensureClient() for the wallet type, and network-dependent operations read the new getSelectedNetwork() helper (unifying the previously inconsistent radio fallbacks on mainnet).

The type extractor learns namespace-function declaration modules and package-level sdk_examples; docs render wallet as `wallet.method` with a local-execution note. A new preserveWhitespace flag keeps the sign-message text and BIP39 passphrase untrimmed, since whitespace there is significant.

Tests: wallet dispatch unit suite, getSelectedNetwork() coverage, namespace-function extractor fixtures, and an e2e suite with deterministic fixtures plus an offline guarantee asserting zero external requests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

thephez and others added 2 commits September 2, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant