feat: restore wallet helpers as a first-class operation type - #79
Draft
thephez wants to merge 3 commits into
Draft
feat: restore wallet helpers as a first-class operation type#79thephez wants to merge 3 commits into
thephez wants to merge 3 commits into
Conversation
Reintroduce the Wallet operation type dropped in the Evo SDK rewrite (4ce19f5), now backed by the package-level `wallet` namespace. Phase 1 adds ten key-generation/utility operations: generate/validate mnemonic, mnemonic to seed, generate key pair(s), key pair from WIF/hex, pubkey to address, validate address, and sign message. Wallet operations run locally in wasm and never touch the platform: executeSelected() skips ensureClient() for the wallet type, and network-dependent operations read the new getSelectedNetwork() helper (unifying the previously inconsistent radio fallbacks on mainnet). The type extractor learns namespace-function declaration modules and package-level sdk_examples; docs render wallet as `wallet.method` with a local-execution note. A new preserveWhitespace flag keeps the sign-message text and BIP39 passphrase untrimmed, since whitespace there is significant. Tests: wallet dispatch unit suite, getSelectedNetwork() coverage, namespace-function extractor fixtures, and an e2e suite with deterministic fixtures plus an offline guarantee asserting zero external requests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduce the Wallet operation type dropped in the Evo SDK rewrite (4ce19f5), now backed by the package-level
walletnamespace. Phase 1 adds ten key-generation/utility operations: generate/validate mnemonic, mnemonic to seed, generate key pair(s), key pair from WIF/hex, pubkey to address, validate address, and sign message.Wallet operations run locally in wasm and never touch the platform: executeSelected() skips ensureClient() for the wallet type, and network-dependent operations read the new getSelectedNetwork() helper (unifying the previously inconsistent radio fallbacks on mainnet).
The type extractor learns namespace-function declaration modules and package-level sdk_examples; docs render wallet as
wallet.methodwith a local-execution note. A new preserveWhitespace flag keeps the sign-message text and BIP39 passphrase untrimmed, since whitespace there is significant.Tests: wallet dispatch unit suite, getSelectedNetwork() coverage, namespace-function extractor fixtures, and an e2e suite with deterministic fixtures plus an offline guarantee asserting zero external requests.