chore(ui): fill 411 missing strings + 15 plural entries across all 42 languages by QuantumExplorer · Pull Request #945 · dashpay/dashwallet-ios

QuantumExplorer · 2026-08-08T23:13:45Z

What

Fills the 411 missing Localizable.strings keys and the 15 missing Localizable.stringsdict plural entries in all 42 non-en localizations. These are the whole SwiftDashSDK-migration era of new UI — the DashPay intro/FAQ/Enable flow, identity public keys, shielded/internal transfer history, Platform balance copy, masternode keys, username voting and the raw-transaction inspector.

Every language goes from 1294 → 1705 keys and 5 → 20 plural entries.

84 files changed, 59214 insertions(+), 0 deletions(-)

One commit per language so a single bad language can be reverted on its own.

⚠️ These translations are machine-generated

They have not been reviewed by a human translator. I raised the Transifex conflict before starting and the owner chose to land them in-repo as a stopgap.

Two consequences worth being explicit about:

A tx pull -a will overwrite this. .tx/config maps DashWallet/<lang>.lproj/Localizable.strings to o:dash:p:dash-mobile-wallets:r:app-localizable-strings. To keep this work, push the en source up (tx push -s) so translators see the 411 new keys, and treat these strings as a placeholder that real translations supersede.
They compete with human translators. Anything here that a translator later corrects should win.

tx is not installed on this machine, so I could not push the source myself.

Terminology decisions

The three balance names had no existing precedent in any of the 42 files, so I had to establish them. Everything else reuses the terminology already in each file (checked per language before writing).

en	choice	rationale
`Platform`, `DashPay`, `Dash`, `CoinJoin`, `InstantSend`, `Orchard`, `Tenderdash`, `duffs`, `TESTNET`, `Evonode`	left untranslated	product / brand names
`Shielded`	translated per language (de abgeschirmt, es blindado, ru экранированный, ja シールド, zh 屏蔽 …)	descriptive English word, not a coined brand; follows each language's established Zcash-ecosystem term
`Transparent`	translated per language	cognate almost everywhere

masternode / evonode / identity / contact request / credits follow each file's existing usage — e.g. tr uses Anadüğüm, ru мастернода, zh 主节点, fil keeps English technical loanwords as that file already does.

Reviewers who disagree with the Shielded/Transparent rendering for their language should change it — it is the one call that was genuinely mine and is applied consistently within each file, so it is cheap to sed.

Verification

Per language, all 42:

plutil -lint clean on both Localizable.strings and Localizable.stringsdict
exactly 1705 string keys / 20 plural entries; no duplicates
format specifiers match en exactly (multiset-compared, %1$@ normalised against %@); the 53 format-bearing strings use positional specifiers wherever word order moves
sort order preserved (stable, case-insensitive — what bartycrouch normalize produces)
insert-only diffs: 0 deletions across all 84 files; every pre-existing line is byte-identical
stringsdict category sets match each locale's CLDR rules — other-only for CJK/SEA, one/other for most European, one/few/other for hr/sr/ro, one/few/many/other for ru/uk/pl/cs/sk, one/two/few/other for sl, zero/one/two/few/many/other for ar

Build:

xcodebuild -workspace DashWallet.xcworkspace -scheme dashpay -sdk iphonesimulator \
  -destination 'generic/platform=iOS Simulator' ARCHS=arm64 build
** BUILD SUCCEEDED **

The build's bartycrouch run-script phase left every file untouched, which independently confirms the formatting and sort order are what the tool expects.

Runtime spot-check against the built bundle (de, ru, ja, pl) — the longest FAQ string resolves, and format specifiers render correctly:

de 2-arg: Der gemeinsame Privatsphäre-Pool wächst noch (3 von 10 Einzahlungen). …
ja 2-arg: 共有プライバシープールはまだ拡大中です（3 / 10 件の入金）。…
de fee  : ~0.0012 DASH (≈ €0.04)

I could not drive the FAQ screen itself in the simulator — the test device sits behind a PIN I don't have — so the FAQ check is bundle-level (string resolves, correct length, correct text) rather than a screenshot.

Pre-existing issues found along the way (not fixed here)

These are all pre-existing and none are introduced by this PR, but they affect how much of this work reaches users:

21 of the 43 .lproj dirs are not in the Xcode target. knownRegions lists only 22 languages + Base. These do not ship in the app today: ar ca da eo et fa fi fil hr hu mk ms nb ro sl sl_SI sq sr sv zh zh_TW. They are still tracked by Transifex, so filling them is not wasted — but adding them to the target is a separate, deliberate decision (it changes the App Store language list).
Localizable.stringsdict ships for only 4 localizations — en, cs, sk, uk. The other 38 stringsdict files are not in the target, so their plural entries never load. Worth fixing separately.
zh-Hans / zh-Hant-TW are near-empty stubs that shadow the real files. zh (909 translated) and zh_TW (908) are the well-translated ones, but only zh-Hans and zh-Hant-TW are in knownRegions — and each had just 43 of 1294 entries translated. So Chinese users have effectively been getting English. I filled all four, so the new strings land correctly either way, and I backfilled the 3 baseline plural entries the two stubs were missing. The pre-existing 1251 untranslated entries in those stubs are still untranslated — worth a follow-up to either populate them from zh/zh_TW or switch knownRegions.
sl (52/1294) and sl_SI (28/1294) are similarly near-empty; neither ships today.

Not done

No human review of any string.
The 3 stale keys each language carries that no longer exist in en were left in place (Platform sync is not running…, Shielded transfer, Shielded transfer (pending)) — harmless, and removing them is bartycrouch's job.
Nothing pushed to Transifex.

🤖 Generated with Claude Code

Summary by CodeRabbit

Localization
- Expanded wallet translations across numerous languages, covering DashPay, usernames, invitations, identities, voting, nodes, balances, transactions, CoinJoin, synchronization, and wallet status.
- Added localized plural forms for vote counts, node counts, selections, contests, requests, merchants, and transactions.
- Improved language-specific handling of singular, plural, and multi-count messages.
- Added broader coverage for guidance, privacy explanations, diagnostics, confirmations, errors, and FAQ content.
- Preserved numeric formatting and translated count-based messages consistently across supported languages.

Machine-generated German translations for the DashPay intro/FAQ/Enable flow, identity public keys, shielded/internal transfers, Platform balance copy, masternode keys, username voting, raw transaction inspector and SPV diagnostics strings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>