This repository was archived by the owner on Apr 9, 2025. It is now read-only.
Update#1
Open
emilienbidet wants to merge 306 commits into
Open
Conversation
Update FRAME_PROCESSOR_PLUGINS_COMMUNITY.mdx
* Android Event Emitter for receiving Bytes when recording Video * Implement Android Event Emitter as it should be for Android Views * working for ios * update docs * small changes * fix lint issues * fix pr comments * chore: Format Swift code --------- Co-authored-by: Felipe Rodriguez Esturo <felipe.rodriguez@humando.co> Co-authored-by: Felipe Rodriguez Esturo <felipe.rodriguez@humand.co> Co-authored-by: Marc Rousavy <me@mrousavy.com>
Added information about the built-in GPU-accelerated frame resizer and converter.
V5 is huge. <img src="https://i.pinimg.com/originals/16/7f/75/167f75d8b3a387e66896316ea084fec8.gif" /> Read the full blog post for more information: https://blog.margelo.com/whats-new-in-visioncamera-v5
* fix: Use `DynamicRangeBitDepth` to avoid unsafe enum case names * Update ResolvableConstraint+VideoDynamicRangeConstraint.swift * Update ResolvableConstraint+VideoDynamicRangeConstraint.swift
…VisionCamera.createNormalizedMeteringPoint(...)` (#3742)
Add 'worklet' directive to getCurrentThreadMarker
* docs: Add note about disposing `Photo` when no longer used * Update CameraPhotoOutput.nitro.ts
Three docs corrections, each verified against the source of truth in
the package:
- recorder.mdx: the `startRecording` example wrapped its callbacks in
an object literal (`startRecording({ (path, reason) => ..., ... })`),
which is a SyntaxError. `startRecording` takes positional arguments
(`onRecordingFinished, onRecordingError, onRecordingPaused?,
onRecordingResumed?`) per Recorder.nitro.ts; the positional form is
already used correctly in video-output.mdx. Rewrote the example to the
positional form.
- photo-quality.mdx: the default JPEG compression was documented as
`0.95` (95% quality). The actual default is `0.9`
(usePhotoOutput.ts uses `quality = 0.9`, and CameraPhotoOutput.nitro.ts
documents `@default 0.9`). Changed `0.95` -> `0.9` and `95%` -> `90%`.
- getCameraDevice.ts: the DeviceFilter.physicalDevices `@example` called
`getCameraDevice({ physicalDevices: [...] })` (single object), but the
signature is `getCameraDevice(devices, position, filter)`. The
function-level `@example` already shows the 3-arg form. Fixed the two
example lines to `getCameraDevice(devices, 'back', { physicalDevices:
[...] })`.
Co-authored-by: Patrick Wehbe <patrick.wehbe.applications@gmail.com>
* feat: Add `'yuv-444-8-bit-full'` * feat: Introduce `PixelRange` to Android pixel format accessor * Add 444 8 bit full to iOS * format * fix accessor sdk * invert, assume FULL by default
…don't discard a valid file) (#4042) fix(android): treat ERROR_SOURCE_INACTIVE as a successful finish CameraX finalizes a valid file on ERROR_SOURCE_INACTIVE (the frames recorded before the source went inactive — e.g. the Activity is stopped/destroyed mid-recording), unlike ERROR_NO_VALID_DATA. Routing it to onRecordingError discards usable footage, so map it to onRecordingFinished(STOPPED) instead, matching expo-camera's handling. ERROR_NO_VALID_DATA stays fatal. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chore: Upgrade Nitro to 0.36.1.
* feat: Support `getDefaultCamera('external')` on Android too
* fix: Replace `CameraPosition` with `TargetCameraPosition`
* add getDefaultCamera test
* guard ios 17 external
* docs: Add Amazon Shopping to showcase * add numbers for amazon * Add OnePay finance * Use B for billion number * order by downloads * 10 more * appstore url is now optional * add more * sort * Update production-apps-showcase.tsx * chore: add `.tmp` to gitignore
* feat: Better `useCameraDevice(...)` including default Cameras * kinda fix with latest main * mark deprecated * Use `Set` * Update useCamera.ts
* chore: Test Frame Output pixel formats end-to-end * test: inline frame pixel format cases
* chore: Test that no `'unknown'` cases exist * way simpler test lol * chore: Also test Pixel Format and Container Format
…onfiguration (#4057) * feat: Add support for passing declarative position to Camera Device configuration * use extension method for default for * implement Swift first idea * fix: Resolve Connections upfront (#4059) * fix: Resolve connections upfront * WIP * ughhhh * rename * Resolve for input * Update HybridCameraSession.swift * Restructure ResolvedCameraSessionConnection to map 1:1 * uhm? * Update HybridCameraController.swift * it builds * custom config type ig * Move out * extract * chore: Lint * remove dead code * impl android hihi * Update ResolvableConstraint+AVAutoFocusSystem.swift * Update CameraSessionConnection+getCameraInfo.kt * chore: Add test for `input: TargetCameraPosition` * re-use CameraSession * Add outputs to the test too * docs * fix: Make `useCameraDeviceExtensions` use `useCameraDeviceFactory()` * Update docs to remove deprecated APIs * clean up
…4062) * chore: Add hook tests * fix: Fix `useCameraDevice` stale on position switch * fix promise rejection deferred test
* fix: Fix unknown Pixel Formats (specifically rgb) * docs * Update PixelFormat+fromImageFormat.kt * remove pixelFormat constraint test
* docs: Add more apps to showcase * add evernote and magicplan * add ATT lol * add more * add momo and sunoco * add guess up, luxer one and party lab * add holodex and mychoice benefits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes
Tested on
Related issues