Repository navigation
Play Count-In opens on the RC-500 - #175
Open
AliceLafox wants to merge 4 commits into
Open
AliceLafox wants to merge 4 commits into
AliceLafox wants to merge 4 commits into
Conversation
Decided 2026-10-29: upload on the two-track model for the one case with no unknowns - a memory with no take on either track - and a refusal in a sentence for the rest, until the pedal has been asked what it makes of a second take of another length beside a pushed one (hardware reading 2026-09-23: a later track 2 came out exactly half of track 1; a non-multiple length is unknown). kRc500 opens push. In commands::push the memory is read through the gate on every path, the drop-only one included, before a byte moves; on a model with more tracks than one, a take on any track - configured or merely in its folder - refuses the push naming that track, force or not. The take lands on track 1 with the body the one-track model gets: TRACK1 WavStat, WavLen, MeasLen, Measure, RecTmp; MASTER Tempo and LpLen, which the pedal keeps as the length of the first recording (2026-09-23), and the pushed take is that recording. CurrentTrack and LpMod stay as the memory has them: single-track recordings off the pedal carry CurrentTrack 0, the factory value, and LpMod 0 on one such memory and 1 on another (2026-09-22), so neither is the recording's doing. The app follows the rule through catalog::uploadOffered: the slot menu's push item, the drag's highlight and the drop land only where an upload is offered; the RC-500's "closed" sentence lists push among the open operations. A push into an empty two-track memory is recorded on track 1 as an RC-5 push is, and a restore of the state before it leaves both tracks empty. rc500_push_tests, from the spec: the empty memory takes the upload with the fields above and track 2's folder untouched; track 1 occupied, track 2 alone, a stray file in a folder - each refused naming the track, the card byte for byte as it was; the drop-only path refused by the same rule and, on a card the gate does not read, before the file lands; the restore. slot_table_harness: a drop on the track-2-only memory calls nobody, on the empty one lands, on an occupied RC-5 slot is a replace. Two mutants against the suite, each caught: the occupancy rule dropped, and the drop-only path reading nothing.
…t asks every track The review found the app offering a push the core refuses: the rule in the app read the config alone (catalog::uploadOffered), while push also looks into the track folders, so a two-track memory with a stray file and an empty config was highlighted, dropped on and listed as a target, and refused only in the toast. offersUpload (PedalWorker.h) now joins the config's say with the folders as the scan listed them, and the menu, the drag's highlight, the drop and the hint all ask it. The empty-slot hint read the flat TRACK1 field: a memory recorded on track 2 alone invited a drop it would not take and a click the core refused; it asks every track now. The greyed Replace item on a used two-track memory says why in its own label, since push is open on the model and the "closed" sentence is for closed operations. The harness presses the hint on the track-2-only and the empty memory, drops on a folder-occupied one, and checks that each drop point maps to its row. Not changed, by the review's reading: the RC-5 path is what it was, byte for byte; the two-track body writes land in TRACK1 and MASTER only; a push into an empty two-track memory records and undoes both tracks. Left open: no model in the table closes push any more, so the drop-only path's profile gate is proven with a card the gate refuses to read, not with a model that closes push.
The feature owns three fields of <RHYTHM> - PlayCount, State, Pattern - and the two-track card lays that section out as the RC-5 does, with the RC-5's numbers: a memory saved on the pedal with the rhythm on, pattern Blank, beat 4/4 reads State 1, Pattern 57, Beat 2, and against the memory's earlier reading exactly State and Pattern had moved (hardware, 2026-11-07). So the profile opens the bit and nothing else changes: the switch does on this card what it does on the RC-5, the #149 rule stands at any beat but 4/4, and the rhythm card stays closed, its pattern and kit lists being charted for the RC-5 only. The app already follows the profile - the column's dot, the inspector's card and the menu all ask CardPermissions - so no app code moves; the sentence a closed control says now lists "set count-in" where the enum puts it, and the harness clicks the dot on a two-track card. A new suite holds the switch to the exact-changed-set standard on a synthetic two-track card: the triple over a silent section, the count alone over a groove, the hand-back, both track sections untouched, the 6/4 refusal with nothing moved, the pair stamped past the highest generation. The field-changes view it shares with commands_tests moves into a test header of its own.
… what the reading did and did not show The header of DeviceProfile.hpp still counted push among the operations unreachable on the two-track model and said nothing of the count-in; the profile suite's header still called that model open for nothing. Both now list the open set as the bitmask has it. The RC-500 comment no longer folds Beat into "the constants the feature writes": the 2026-11-07 reading showed State, Pattern and Beat, while the feature writes PlayCount, State and Pattern - PlayCount's 1 = 1MEAS is the RC-5's reading (2026-08-10) carried over on the identical layout, and the first count heard from this pedal is what confirms it. Copyright lines of the two new files take the tree's dash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Play Count-In opens on the RC-500:
kRc500.operationsgainsOperation::setCountIn. Nothing else in the profile moves; the rhythm card (setRhythm) and Start/Stop stay closed on this model.Why
The feature owns three fields of
<RHYTHM>- PlayCount, State, Pattern - and the two-track card lays that section out as the RC-5 does, with the RC-5's numbers. Hardware reading, 2026-11-07: a memory saved on the pedal with the rhythm on, pattern Blank, beat 4/4 readsState 1,Pattern 57,Beat 2, and against the memory's earlier reading exactly State and Pattern had moved. Those arerc0::kRhythmStateOn,rc0::kRhythmPatternBlankandbeat::kBeatFourFour.PlayCount 1 = 1MEASis the RC-5's reading (2026-08-10) carried over on the identical layout; the pedal checkpoint below is what confirms it.What the app does
No app code changes: the column's dot, the inspector's card and the context menu already ask
CardPermissions, which reads the profile. The sentence a still-closed control says now reads, in the enum's order:On the RC-500, LooperCat does rename, set one-shot, push, pull, clear and restore onlyOn the RC-500, LooperCat does rename, set one-shot, set count-in, push, pull, clear and restore onlyDerived from the open set laid in
Operationenum order before comparing withopenOperations(); the two agree.Tests
device_profile_tests:require(kRc500, setCountIn)passes; the closed-op sentence listsset count-in.rc500_count_in_testson a synthetic two-track card, held to the exact-changed-set standard: on over a silent section changesRHYTHM.Pattern 0->57, RHYTHM.PlayCount 0->1, RHYTHM.State 0->1and not a byte elsewhere; on over a playing groove movesPlayCountalone; off hands a borrowed section back and the document round-trips to the byte;TRACK1/TRACK2and every take untouched; at 6/4 the borrow is refused with the Do not name or write a rhythm pattern for a memory whose time signature we have not charted #149 words and nothing on the volume moves, a 4/4 memory ahead in the batch included; the count alone at 6/4 is still written; both banks carry one document stamped past the highest generation; a card of an unknown model is refused at the door.slot_table_harness: the Count-In dot on a two-track card fires its click; the 6/4 dot is a lamp with the same hover as on the RC-5.fieldChanges,slotChangesOnCard) moves fromcommands_tests.cppintotests/field_changes.hpp, shared by both suites.Mutants (applied, built, run, restored):
kRc500again:device_profile_tests,rc500_count_in_tests,card_permissions_tests,slot_table_harnessall fail (4 of 4);countin::applywriting Pattern at any beat:rc500_count_in_testsfails on every 6/4 check (no throw, Pattern 3 -> 57, volume moved),usecase_count_in_testsandcommands_testsfail too.Full
ctest(86 non-harness suites incl.utf8_literals_lint, 8 harnesses) green; no new warning sites against the branch's baseline.Headless proof
--snapshot --volume <folder>on a card folder built from the synthetic two-track memory with the Play Count-In column on: the dot is live on an RC-500 card (a memory with the count on draws the filled lilac dot; the 6/4 memory's dot is dimmed to a lamp, measured on the PNG), the inspector's Play Count-In card is enabled, says "Switching it on replaces a rhythm pattern chosen on the pedal." on a memory with a silent groove and the 6/4 refusal line on the lamp, and the footer carries the new sentence.Pedal checkpoint (before merging)
On the RC-500: switch Play Count-In on for a 4/4 memory with a take, save, disconnect, press PLAY on the pedal - one bar of count (silent, Blank) and then the loop. That is the reading that confirms
PlayCount 1means 1MEAS on this model.Based on #174 (
feat/rc500-push-empty-memory); rebases onto main once that lands.