Skip to content

The solo buttons say the way back, and a harness presses them - #173

Open
AliceLafox wants to merge 2 commits into
mainfrom
fix/player-solo-hint
Open

AliceLafox wants to merge 2 commits into
mainfrom
fix/player-solo-hint

Conversation

@AliceLafox

Copy link
Copy Markdown
Member

What happened

On 2026-10-25 a player soloed a track in the preview of a two-track memory and could not find how to hear both again. The way is the lit button itself, and nothing said so. Decided 2026-11-06: no Mix button; the T1 / T2 solo toggles stay as they are, and they say the way back.

The change

  • Tooltips on both sides of the click (app/PlayerPane.cpp, refreshSoloTips): unlit, Solo track 1 - click again to hear both; lit, Only track 1 is playing - click to hear both (same for track 2). They follow the toggles through a press, a load and a clear. No new button, no new engine call, nothing a click does changes.
  • The harness presses the buttons (tests/player_pane_harness.cpp, new section): they never had a test. From the spec: a two-track memory shows both unlit with the engine playing both; a press solos the track, lights the button, names the way back and draws the other lane dim; the second press brings both back; the other button takes the solo and releases the first; a load starts with both again; a one-track memory shows no buttons.
  • The dim lane is measured, not assumed: a snapshot of the pane, the waveform's violet counted past the background's faint blue, lane by lane. Under a solo the muted lane's ink falls to well under 0.6 of what it was while the other lane keeps over 0.8 of its own; the way back lights it again.

Mutants, each caught

  • A press that leaves the other button lit (the release loop in soloPressed dropped): player_pane_harness.cpp:395 (T1 still lit beside T2) and :396 (the tooltips).
  • A load that leaves the buttons lit (the toggle reset in applyTracks dropped): :400 and :401. The engine's own solo reads 0 after a load regardless, since a load builds a fresh mix, so the buttons are the guard, as the harness now says beside the check.
  • From the review: a lane that is never dimmed (the alpha forced to 0.85): :382.

Not changed

docs/guide.md's player paragraph describes seek, play and Loop only and never mentions T1 / T2, so it is as it was.

Verified

macOS: 84 of 84 suites and 8 of 8 harnesses pass, UTF-8 lint included; player_pane_harness runs 106 checks.

On 2026-10-25 a player soloed a track in the preview and could not find
how to hear both again; the way is the lit button itself. The tooltips now
say so on both sides of the click: an unlit button reads "Solo track 1 -
click again to hear both", a lit one "Only track 1 is playing - click to
hear both". No new button, no new engine call, nothing a click does
changes; the tooltips follow the toggles through a press, a load and a
clear.

player_pane_harness never pressed T1 or T2. It does now, from the spec: a
two-track memory shows both unlit with the engine playing both; a press
solos the track, lights the button, names the way back and draws the other
lane dim - measured on a snapshot, as the waveform's violet past the
background's faint blue; the second press brings both back; the other
button takes the solo and releases the first; a load starts with both
again; a one-track memory shows no buttons. Two mutants against it, each
caught: a press that leaves the other button lit, and a load that leaves
the buttons lit.
…'s guard is named

The review - fresh eyes, with a mutant of its own that never dims a lane,
caught at the lane check - found no bug and two nits. laneInk mapped the
snapshot once per pixel; now once per snapshot. And the engine's solo after
a load reads 0 by itself, since a load builds a fresh mix, so the check that
catches a forgotten reset is the buttons' - said beside it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant