Repository navigation
The solo buttons say the way back, and a harness presses them - #173
Open
AliceLafox wants to merge 2 commits into
Open
AliceLafox wants to merge 2 commits into
AliceLafox wants to merge 2 commits into
Conversation
On 2026-10-25 a player soloed a track in the preview and could not find how to hear both again; the way is the lit button itself. The tooltips now say so on both sides of the click: an unlit button reads "Solo track 1 - click again to hear both", a lit one "Only track 1 is playing - click to hear both". No new button, no new engine call, nothing a click does changes; the tooltips follow the toggles through a press, a load and a clear. player_pane_harness never pressed T1 or T2. It does now, from the spec: a two-track memory shows both unlit with the engine playing both; a press solos the track, lights the button, names the way back and draws the other lane dim - measured on a snapshot, as the waveform's violet past the background's faint blue; the second press brings both back; the other button takes the solo and releases the first; a load starts with both again; a one-track memory shows no buttons. Two mutants against it, each caught: a press that leaves the other button lit, and a load that leaves the buttons lit.
…'s guard is named The review - fresh eyes, with a mutant of its own that never dims a lane, caught at the lane check - found no bug and two nits. laneInk mapped the snapshot once per pixel; now once per snapshot. And the engine's solo after a load reads 0 by itself, since a load builds a fresh mix, so the check that catches a forgotten reset is the buttons' - said beside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
On 2026-10-25 a player soloed a track in the preview of a two-track memory and could not find how to hear both again. The way is the lit button itself, and nothing said so. Decided 2026-11-06: no Mix button; the T1 / T2 solo toggles stay as they are, and they say the way back.
The change
app/PlayerPane.cpp,refreshSoloTips): unlit,Solo track 1 - click again to hear both; lit,Only track 1 is playing - click to hear both(same for track 2). They follow the toggles through a press, a load and a clear. No new button, no new engine call, nothing a click does changes.tests/player_pane_harness.cpp, new section): they never had a test. From the spec: a two-track memory shows both unlit with the engine playing both; a press solos the track, lights the button, names the way back and draws the other lane dim; the second press brings both back; the other button takes the solo and releases the first; a load starts with both again; a one-track memory shows no buttons.Mutants, each caught
soloPresseddropped):player_pane_harness.cpp:395(T1 still lit beside T2) and:396(the tooltips).applyTracksdropped)::400and:401. The engine's own solo reads 0 after a load regardless, since a load builds a fresh mix, so the buttons are the guard, as the harness now says beside the check.:382.Not changed
docs/guide.md's player paragraph describes seek, play and Loop only and never mentions T1 / T2, so it is as it was.Verified
macOS: 84 of 84 suites and 8 of 8 harnesses pass, UTF-8 lint included;
player_pane_harnessruns 106 checks.