fix(okf): strip local media paths from export text#50
Merged
Conversation
Move local-media-path filtering into shared OKF text rendering so raw source extracts, item evidence, summaries, excerpts, and section bodies do not leak generated `Local Path`, `local_path`, or generated `Local:` media metadata into OKF bundles. Previously the filter only covered X media transcript evidence. Source-level raw text and derived text could still expose machine-local media paths in exported artifacts. The export now preserves surrounding evidence while dropping only the generated local path metadata lines. Risk: the heuristic is intentionally narrow but not schema-aware, so a user-authored line that exactly matches generated local-path metadata may also be removed. Follow-up: keep any future generated filesystem metadata behind this shared filter, or prevent it from entering export-bound body text in the first place.
PR Diff StatsPR #50 changed 4 file(s), with +35 / -18 (53 changed lines).
Largest Changed Files
Bucket rules
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move local-media-path filtering into shared OKF text rendering so raw source extracts, item evidence, summaries, excerpts, and section bodies do not leak generated
Local Path,local_path, or generatedLocal:media metadata into OKF bundles.Previously the filter only covered X media transcript evidence. Source-level raw text and derived text could still expose machine-local media paths in exported artifacts. The export now preserves surrounding evidence while dropping only the generated local path metadata lines.
Risk: the heuristic is intentionally narrow but not schema-aware, so a user-authored line that exactly matches generated local-path metadata may also be removed.
Follow-up: keep any future generated filesystem metadata behind this shared filter, or prevent it from entering export-bound body text in the first place.