Skip to content

themes: make focused/expanded border honor rounded corner settings - #22675

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
masterpiga:rounded-border-accent-fix
Oct 18, 2026
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
masterpiga:rounded-border-accent-fix

Conversation

@masterpiga

Copy link
Copy Markdown
Collaborator

Summary

Ensures that, if rounded borders is enabled, the border highlight respect the border radius.

Also, fixes issue with styles not being unloaded correctly, which prevented some CSS tweaks to take effect without a restart.

Screen.Recording.2026-10-18.at.10.47.07.mp4

Referenced issue

This is somehow related to the discussion in #22655. The highlighted border for focused modules is a very good way of making the focused module much more prominent.

Checklist

  • I have read CONTRIBUTING.md and the coding style.
  • I have not merged master into the topic branch.
  • The pull request is one logical change, and every commit compiles on its own.
  • I ran the relevant tests: unit tests, src/tests/integration/ where the pixelpipe is touched, or darktable-cli as a headless smoke test.
  • New user-visible strings use _(), new preferences are registered in data/darktableconfig.xml.in.
  • A RELEASE_NOTES.md entry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.

AI assistance

Co-authored with Claude.

With rounded module headers enabled, the focused and expanded module
borders now follow the header's rounded corner instead of staying square.
Turning a theme option off in preferences also takes effect right away,
where before the old styling lingered until darktable was restarted.
@masterpiga masterpiga added this to the 5.8 milestone Oct 18, 2026
@masterpiga masterpiga added priority: low core features work as expected, only secondary/optional features don't difficulty: trivial some changes in a couple of functions scope: UI user interface and interactions ai:generated labels Oct 18, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@TurboGit
TurboGit merged commit 1852a5f into darktable-org:master Oct 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai:generated difficulty: trivial some changes in a couple of functions priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants