Repository navigation
Conversation
TurboGit
reviewed
Oct 18, 2026
TurboGit
approved these changes
Oct 18, 2026
TurboGit
left a comment
TurboGit
left a comment
Member
There was a problem hiding this comment.
Yes, agreed... that's strange that this call was there but you are right there is no clear or valid reason!
Collaborator
Author
Yes, there is no reason, it's just a mistake. It’s nothing surprising; we’re all human, and no one is immune to making mistakes. We get tired, distracted, lose focus, or shift our attention to a different part of the code while writing; sometimes we’re in a rush to finish a task when time is short. It’s just an interesting detail that this code was written by AP; I sometimes find it a bit amusing to hear him attacking other programmers, given that his own code is hardly a model of perfection. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the addition of noise, which is immediately discarded as the buffer is overwritten by the result of applying Gaussian blur. So, this removed
make_noisecall was wasted work. What actually works is themake_noisepost-processing at the end of the function.Removing unnecessary buffer processing will obviously speed up the module, though I haven’t measured by how much. I also don't think that such a speed-up would be noticeable to the user. So, I suggest not mentioning this fix in the release notes.