Repository navigation
Conversation
With target white luminance above 100% for HDR output, the look only and look + mapping (lin/log) graphs kept their y axis at 0-100%, so the shoulder and the white node were drawn past the top of the graph and clipped. Only the dynamic range mapping view reflected the value. Stretch the y axis of those three views to the curve's white point when it is above 1, keep the grid on the 0-100% part, and draw a line and a "100" label at 100% display so the headroom stays readable. At 100% or below the graphs are unchanged. Related: darktable-org#16403 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATMdEKR7uukHKWPW8rTX14
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATMdEKR7uukHKWPW8rTX14
Author
|
Two things look off at 400% that are not from this change:
|
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filmic rgb accepts target white luminance up to 1600% for HDR output, but its look only and look + mapping (lin/log) graphs kept a fixed 0-100% y axis. Above 100% the shoulder and the white node were drawn past the top of the graph and clipped, so the graph no longer showed what the module did. Those three views now stretch their y axis to the curve's white point, keep the grid on the 0-100% part, and mark 100% display with a line and a "100" label. At 100% or below the graphs look exactly as before. The dynamic range mapping view already handled the value and is unchanged.
Referenced issue
Related: #16403
The issue also discusses HDR display and 10-bit output, which this does not address; it fixes the graph scaling the issue reports.
Checklist
src/tests/integration/where the pixelpipe is touched, ordarktable-clias a headless smoke test._(), new preferences are registered indata/darktableconfig.xml.in.RELEASE_NOTES.mdentry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.Test instructions
Done so far:
Not verified: macOS and Windows, HiDPI scaling. No pixel output changes: only
dt_iop_tonecurve_draw()insrc/iop/filmicrgb.cis touched, so integration tests were not run.AI assistance: written with Claude Code.