Repository navigation
masks: stop the canvas shifting when module focus changes - #22659
Merged
Merged
Conversation
With the mask panel on the canvas, its 1px edge strips were shown and hidden with module focus. They are columns beside the canvas, so every focus change resized the canvas and moved the image by a pixel. The strips now keep their room while the darkroom uses the canvas position, whatever is focused. With no panel to show they paint the canvas margin color and ignore input.
TurboGit
approved these changes
Oct 17, 2026
TurboGit
left a comment
Member
There was a problem hiding this comment.
Works for me, thanks!
A question, I don't remember having seen that when testing the flexi panel since some weeks... Is there a recent change that could explain that or was I blind ? :)
Collaborator
Author
Not something that I changed on purpose. I think it's always been there, it's just that one notices only after un-focusing a module. If you jump between modules that can be masked nothing shifts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the mask panel on the canvas, its 1px edge strips were shown and hidden with module focus. They are columns beside the canvas, so every focus change resized the canvas and moved the image by a pixel.
The strips now keep their room while the darkroom uses the canvas position, whatever is focused. With no panel to show they paint the canvas margin color and ignore input.
Screen.Recording.2026-10-17.at.18.31.18.mp4
Referenced issue
Fixes #22651
Checklist
src/tests/integration/where the pixelpipe is touched, ordarktable-clias a headless smoke test._(), new preferences are registered indata/darktableconfig.xml.in.RELEASE_NOTES.mdentry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.Test instructions
AI assistance
Co-authored with Claude.