Skip to content

Fix: 22622 css thumb cursor - #22653

Merged
TurboGit merged 2 commits into
darktable-org:masterfrom
rtmongold:fix/22622-css-thumb-cursor
Oct 17, 2026
Merged

TurboGit merged 2 commits into
darktable-org:masterfrom
rtmongold:fix/22622-css-thumb-cursor

Conversation

@rtmongold

Copy link
Copy Markdown
Contributor

Summary

The traiangle fill was taken from the named color bg_color, so rules on #thumb-cursor had no effect. Read the widget color again, and set the active filmstrip rule to @bg_color so the default appearance is unchanged.

Referenced issue

Fixes #22622

Checklist

  • I have read CONTRIBUTING.md and the coding style.
  • I have not merged master into the topic branch.
  • The pull request is one logical change, and every commit compiles on its own.
  • I ran the relevant tests: unit tests, src/tests/integration/ where the pixelpipe is touched, or darktable-cli as a headless smoke test.
  • New user-visible strings use _(), new preferences are registered in data/darktableconfig.xml.in.
  • A RELEASE_NOTES.md entry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.

Test instructions

Set CSS to:

#thumbtable-filmstrip #thumb-main:active #thumb-cursor
{
  color: red;
}

Open darkroom, the triangle fill should be red and the outline unchanged.

The traiangle fill was taken from the named color bg_color, so rules on
#thumb-cursor had no effect. Read the widget color again, and set the
active filmstrip rule to @bg_color so the default appearance is
unchanged.
@TurboGit TurboGit added this to the 5.8 milestone Oct 17, 2026
@TurboGit TurboGit added scope: UI user interface and interactions bugfix pull request fixing a bug labels Oct 17, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, works on my side, thanks for fixing.

@TurboGit
TurboGit merged commit 696b28f into darktable-org:master Oct 17, 2026
5 checks passed
@rtmongold
rtmongold deleted the fix/22622-css-thumb-cursor branch October 17, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS for #thumb-cursor has no effect

2 participants