feat: log version on startup - #31
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe release workflow passes its tag as a Docker build argument. The Dockerfile embeds that value in the Go binary. The application logs the version at startup, with tests validating the info message. ChangesVersioned startup logging
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Release images now embed their release tag and log it at startup, while local builds retain a dev version. The version flow and startup message are covered, with no remaining merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant PublishWorkflow
participant DockerBake
participant Dockerfile
participant Doormouse
participant StdLogger
PublishWorkflow->>DockerBake: Pass release tag as VERSION
DockerBake->>Dockerfile: Provide VERSION build argument
Dockerfile->>Doormouse: Embed VERSION in main.version
Doormouse->>StdLogger: Log startup version before argument parsing
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 unsupported.) Full details: TestsExplanation The added test only calls Resolution Add an integration-level test for the startup path. Use a testable startup function or execute a built binary with
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit