Skip to content

feat: add a dry run option to the sync modal - #279

Merged
darksworm merged 2 commits into
mainfrom
feat/sync-dry-run-option
Sep 6, 2026
Merged

feat: add a dry run option to the sync modal#279
darksworm merged 2 commits into
mainfrom
feat/sync-dry-run-option

Conversation

@darksworm

@darksworm darksworm commented Aug 18, 2026

Copy link
Copy Markdown
Owner

d toggles a dry run. Argo CD runs the same pre-flight it already gates every sync behind (kubectl apply --dry-run over all manifests), reports per-resource results, and applies nothing.

Two interactions with force, both from the same fact — a client-side dry run never touches a live resource:

  • force renders dim with inert in dry run instead of red delete & recreate
  • the force confirmation is skipped; there is nothing to guard

Reads Sync (dry run) in the pane afterwards, from #277.

Stacked on #278.

Summary by CodeRabbit

  • New Features
    • Added a dry-run option to single- and multi-application syncs.
    • Toggle dry-run mode with the d key in the sync confirmation dialog.
    • Dry-run requests validate changes without applying them.
    • Force confirmation is skipped during dry runs, and the dialog indicates that force has no effect.
  • Bug Fixes
    • Preserved existing prune, force, error-handling, and completion behavior for standard syncs.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 1c860710-d7dd-45c6-977f-f6627ceea904

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 8 files. (2 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Tests ✅ Passed The dry-run feature has meaningful coverage at each important layer. cmd/app/sync_dry_run_test.go checks the d key, immediate start when force is combined with dry run, and inert force rendering. …
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a dry-run option to the sync modal.
Full details: Docstring Coverage

Explanation

Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 8 files. (2 skipped: 2 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@darksworm

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@darksworm
darksworm force-pushed the feat/sync-dry-run-option branch from 3942ddf to 6b858e6 Compare August 18, 2026 22:09
@darksworm

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@darksworm
darksworm force-pushed the feat/sync-dry-run-option branch from 6b858e6 to f831dcb Compare August 18, 2026 22:16
@darksworm
darksworm force-pushed the feat/sync-force-option branch from e37f044 to c8dc12b Compare September 6, 2026 09:06
@darksworm
darksworm force-pushed the feat/sync-dry-run-option branch from f831dcb to 93890e9 Compare September 6, 2026 10:11
@darksworm
darksworm changed the base branch from feat/sync-force-option to main September 6, 2026 10:11
@darksworm
darksworm merged commit 326623c into main Sep 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant