Skip to content

FAdd a minor fix for the b:plist_original_format;#3

Open
axrt wants to merge 1 commit into
darfink:masterfrom
axrt:master
Open

FAdd a minor fix for the b:plist_original_format;#3
axrt wants to merge 1 commit into
darfink:masterfrom
axrt:master

Conversation

@axrt

@axrt axrt commented Oct 20, 2020

Copy link
Copy Markdown

Hi darfink!
First of all, thank you for the plugin, it is really useful.
I have encountered an issue with g:plist_original_format variable in the following context:
the autogroup in the plugin file calls plist#SetFiletype() and then checks if the file format is set to json. because i originally had it set to xml, i was receiving an error complaining about the b:plist_original_fromat not having been set. same with write..
This is introduced just a tiny fix for those situations; I would be ver glad if you choose to accept this pr.
Cheers,
axrt

@darfink

darfink commented Oct 21, 2020

Copy link
Copy Markdown
Owner

Hi Axrt!

Thanks for your pull request, this seems like a very reasonable addition!
I'd would like to ask though, if there are any easy steps to recreate the issue you are describing so I can test it out myself?

@axrt

axrt commented Nov 23, 2020

Copy link
Copy Markdown
Author

Hi @darfink,
Sorry I got caught in mundane stuff and forgot.
So, eventually, the only setting I used to have was:

let g:plist_display_format = 'xml'
let g:plist_original_format = 'xml'

and then I was trying to open one of the .plist files on my mac (those are xmls). Please let me know if I can test anything else on my end for you.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants