Repository navigation
Fixing actors.next registration for multiple IHostedService registrations - #1932
Merged
Merged
Conversation
…numerable wrapper TryAddSingleton<IHostedService> deduplicates by service type alone, so any hosted service the application registered before the first AddDaprActorsCore call (OpenTelemetry, Dapr workflows, app hosted services, ...) suppressed the registration entirely. The stream manager then never started, no actor types were announced to placement, and every actor invocation failed with 'did not find address for actor'. Register a dedicated SubscribeActorEventsStreamHostedService wrapper through TryAddEnumerable, which deduplicates by implementation type: added exactly once across repeated AddDaprActorsCore calls, never suppressed by unrelated hosted services, and never double-started. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
- Coverage 64.86% 64.84% -0.02%
==========================================
Files 360 360
Lines 10612 10612
Branches 1252 1252
==========================================
- Hits 6883 6881 -2
- Misses 3388 3390 +2
Partials 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register SubscribeActorEventsStreamManager hosted service via TryAddEnumerable wrapper
TryAddSingleton deduplicates by service type alone, so any hosted service the application registered before the first AddDaprActorsCore call (OpenTelemetry, Dapr workflows, app hosted services, ...) suppressed the registration entirely. The stream manager then never started, no actor types were announced to placement, and every actor invocation failed with 'did not find address for actor'.
Register a dedicated SubscribeActorEventsStreamHostedService wrapper through TryAddEnumerable, which deduplicates by implementation type: added exactly once across repeated AddDaprActorsCore calls, never suppressed by unrelated hosted services, and never double-started.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: