fix: rename with proto changes#1629
Merged
Merged
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
There was a problem hiding this comment.
Pull request overview
Aligns the CLI’s workflow history parsing/output with upstream Durable Task / Dapr proto renames, and bumps Go module dependencies to versions that include those proto changes.
Changes:
- Update workflow history event handling to use renamed proto fields/events (e.g.,
WorkflowInstance,WorkflowStarted,ChildWorkflowInstance*). - Update workflow status mapping to the renamed
WorkflowStatusfield. - Bump Dapr/DurableTask-Go (and related) module versions in
go.mod/go.sum.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/workflow/history.go | Renames proto event/field usage for workflow history display and derived metadata. |
| go.mod | Updates Go module versions to pull in proto changes; includes an extra trailing comment. |
| go.sum | Records checksum updates for the dependency version changes. |
Comments suppressed due to low confidence (1)
go.mod:275
- The trailing commented-out local
replace github.com/dapr/dapr => ../daprlooks like a leftover from local development. Please remove it before merging to avoid confusion about the module's intended dependency graph.
sigs.k8s.io/controller-runtime v0.19.0 // indirect
sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
sigs.k8s.io/kustomize/api v0.19.0 // indirect
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Contributor
Author
|
e2e test failures are unrelated from what I can tell |
cicoyle
previously approved these changes
Apr 13, 2026
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
lgtm, thx for doing this! 🎉
4 tasks
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
cicoyle
approved these changes
May 11, 2026
3 tasks
cicoyle
pushed a commit
to WhitWaldo/dapr-cli
that referenced
this pull request
May 22, 2026
The E2E - KinD non-HA matrix has been red for 10 days (since 2026-05-11). TestRenewCertificateMTLSEnabled hangs at the 25-minute suite timeout in the "Renew certificate which expires in less than 30 days" subtest. Root cause: PR dapr#1629 bumped github.com/dapr/dapr from v1.17.3 to a pseudo-version (commit f8d0f6142987, 2026-04-25) to pull in the workflow proto renames. That commit also includes #9598 (Sentry: Ed25519 for X.509 cert key generation, merged 2026-03-18). The CLI now generates Ed25519 root/issuer certs via bundle.GenerateX509(). The E2E pinned runtime was 1.17.3, whose sentry cannot parse Ed25519 keys -- it crashes on startup with "unsupported key type ed25519.PrivateKey" (a known issue documented in the 1.18 release notes as the "rollback floor is 1.17.7" caveat). After the cert renewal step, sentry crash-loops and the post-renewal `kubectl rollout status` call (which has no timeout) blocks until the 25-minute test alarm fires. Bumping the pinned version to 1.17.7 -- the first stable release that includes the Ed25519 PEM-decoder fix (dapr/dapr#9904) -- aligns the E2E runtime with the minimum compatible sentry for a 1.18 CLI. Only non-HA matrix legs were affected because TestRenewCertificateMTLSEnabled is skipped in HA mode (DaprModeNonHA guard at the top of the test). Note: the unbounded `kubectl rollout status` in `restartControlPlaneService` is a separate latent bug that turned this incompatibility into a 25-min hang instead of a clean failure. Worth fixing in a follow-up. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Precursor to #1628 that I stumbled upon in testing my local changes.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: