DAOS-19150 bio: add percentage_used to nvme stats by johannlombardi · Pull Request #18486 · daos-stack/daos

johannlombardi · 2026-06-11T20:10:38Z

Add (lifetime) percentage_used NVMe statistic to the nvme_stats
structure which is returned in dmg storage scan --nvme-health and
dmg storage query list-devices --health commands. This value is a
SMART stat and returned through a SPDK health page fetch. Add the same
value to the list of NVMe health metrics stored.

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

Report percentage_used via the nvme health metrics. Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

github-actions · 2026-06-11T20:10:55Z

Ticket title is 'Add NVMe Controller Lifetime Percentage Used to Health Statistics'
Status is 'In Review'
Labels: 'linkedin'
https://daosio.atlassian.net/browse/DAOS-19150

daosbuild3 · 2026-06-11T20:14:46Z

Test stage Build on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/1/execution/node/269/log

daosbuild3 · 2026-06-11T20:14:54Z

Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/1/execution/node/263/log

daosbuild3 · 2026-06-11T20:22:23Z

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/1/execution/node/344/log

Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

daosbuild3 · 2026-06-11T20:27:31Z

Test stage Build on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/2/execution/node/280/log

daosbuild3 · 2026-06-11T20:27:38Z

Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/2/execution/node/273/log

daosbuild3 · 2026-06-11T20:28:45Z

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/2/execution/node/344/log

Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

NiuYawei

I suppose it requires some control plane changes to display the new metric? @tanabarr

tanabarr

there needs to be updated to health stats printers on the go code and possibly some updates on the metric side, would you like me to add the missing parts @johannlombardi ?

daosbuild3 · 2026-06-12T14:36:37Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18486/3/testReport/

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Features: control metrics Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-06-19T09:50:30Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18486/5/display/redirect

Test-tag: pr control hw,medium,test_nvme_telemetry_metrics Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-06-19T23:58:11Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18486/7/testReport/

janekmi · 2026-06-22T04:39:51Z

 // versions:
 // 	protoc-gen-go v1.34.1
-// 	protoc        v3.5.0
+// 	protoc        v3.14.0


Judging from the generated outputs it is not a problem. But for the record: can we change the version of these generators willy-nilly or should we strive to stick to one agreed version?

we should stick to the one in go.mod, I will fix

The instructions for development of go code is //docs.daos.io/latest/dev/development/ , libprotoc isn't tracked in go.mod so the rule of thumb is to use the distro version which is 3.14.0 in Rocky >= 9.7. Does that sound okay?

daltonbohning

ftest changes LGTM

daosbuild3 · 2026-06-23T22:01:14Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18486/8/testReport/

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr · 2026-06-24T12:04:20Z

@daltonbohning do the changes look sufficient for coverage in ftest? I got stuck adding extra coverage because I didn't know which value limits to apply without introducing intermittent failures.

tanabarr · 2026-06-24T15:05:43Z

implementation needs fixing, health stats are not being updated

[nabarrot@edaos-15 daos]$ install/bin/dmg storage scan -i -l edaos-[15] --nvme-health| grep ercent
    Percentage Used:0%
    Percentage Used:0%
    Percentage Used:0%
    Percentage Used:0%
[nabarrot@edaos-15 daos]$ install/bin/dmg storage query usage -i -l edaos-[15]
Hosts    SCM-Total SCM-Free SCM-Used NVMe-Total NVMe-Free NVMe-Used
-----    --------- -------- -------- ---------- --------- ---------
edaos-15 1.6 TB    798 GB   50 %     32 TB      16 TB     49 %
[nabarrot@edaos-15 daos]$

Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-06-24T16:41:27Z

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18486/9/execution/node/1041/log

daltonbohning

ftest LGTM. Some of the changes were backed out so just let me know if you still need me to look into something else ftest-related

daosbuild3 · 2026-06-24T17:56:00Z

Test stage Unit Test with memcheck completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18486/10/testReport/

tanabarr · 2026-06-25T12:44:05Z

ftest LGTM. Some of the changes were backed out so just let me know if you still need me to look into something else ftest-related

I couldn't get the extra changes that added coverage to work, mainly because of the range requirements and choosing an upper limit that would work for all permutations. if you think the coverage is okay in its existing form then I will leave as is, if you think other changes need to be made please let me know.

Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

…spdk-stats Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-06-29T12:37:59Z

Test stage Unit Test with memcheck completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18486/11/testReport/

DAOS-19150 bio: add percentage_used to nvme stats

d9be5d8

Report percentage_used via the nvme health metrics. Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

johannlombardi requested review from a team as code owners June 11, 2026 20:10

fix typo

d0442ff

Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

fix another nit

dadcc67

Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

johannlombardi requested review from NiuYawei, kjacque and tanabarr June 11, 2026 20:54

NiuYawei reviewed Jun 12, 2026

View reviewed changes

tanabarr requested changes Jun 12, 2026

View reviewed changes

tanabarr added 3 commits June 18, 2026 15:32

add protobuf shims and missing stat field

9be08ef

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Merge remote-tracking branch 'origin/master' into jlo/spdk-stats

ef3188f

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

address unit test failures

f1a9d0d

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr requested review from a team as code owners June 18, 2026 14:58

tanabarr added 2 commits June 18, 2026 19:02

add test fixes

215ac3f

Features: control metrics Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

add missing field entries to structs

76b9f77

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr requested review from a team as code owners June 19, 2026 09:49

add ftest coverage

35999ed

Test-tag: pr control hw,medium,test_nvme_telemetry_metrics Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

janekmi previously approved these changes Jun 22, 2026

View reviewed changes

daltonbohning reviewed Jun 23, 2026

View reviewed changes

tanabarr added 2 commits June 24, 2026 12:51

Merge remote-tracking branch 'origin/master' into jlo/spdk-stats

ea1f290

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

revert failing ftest change

9791bfd

Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr dismissed janekmi’s stale review via 9791bfd June 24, 2026 12:02

add missing plumbing for percentage used stat

7a7d67d

Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daltonbohning reviewed Jun 24, 2026

View reviewed changes

tanabarr requested review from NiuYawei, daltonbohning, janekmi and tanabarr June 25, 2026 14:01

tanabarr approved these changes Jun 25, 2026

View reviewed changes

tanabarr added 2 commits June 28, 2026 05:18

Merge remote-tracking branch 'origin/master' into jlo/spdk-stats

a721901

Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

Merge branch 'jlo/spdk-stats' of github.com:daos-stack/daos into jlo/…

310190a

…spdk-stats Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

NiuYawei approved these changes Jun 29, 2026

View reviewed changes

Uh oh!

Conversation

johannlombardi commented Jun 11, 2026 • edited by tanabarr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Jun 11, 2026

Uh oh!

daosbuild3 commented Jun 11, 2026

Uh oh!

daosbuild3 commented Jun 11, 2026

Uh oh!

daosbuild3 commented Jun 11, 2026

Uh oh!

daosbuild3 commented Jun 11, 2026

Uh oh!

daosbuild3 commented Jun 11, 2026

Uh oh!

NiuYawei left a comment

Choose a reason for hiding this comment

Uh oh!

tanabarr left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Jun 12, 2026

Uh oh!

daosbuild3 commented Jun 19, 2026

Uh oh!

daosbuild3 commented Jun 19, 2026

Uh oh!

janekmi Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

daltonbohning left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Jun 23, 2026

Uh oh!

tanabarr commented Jun 24, 2026

Uh oh!

tanabarr commented Jun 24, 2026

Uh oh!

daosbuild3 commented Jun 24, 2026

Uh oh!

daltonbohning left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Jun 24, 2026

Uh oh!

tanabarr commented Jun 25, 2026

Uh oh!

daosbuild3 commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

johannlombardi commented Jun 11, 2026 •

edited by tanabarr

Loading

github-actions Bot commented Jun 11, 2026 •

edited

Loading