feat: replace legacy samples with .NET 10 MAUI AppManifests sample - #364
feat: replace legacy samples with .NET 10 MAUI AppManifests sample#364dansiegel wants to merge 22 commits into
Conversation
|
No blockers found. One minor doc issue remains: I validated this with .NET and workload restore/build checks on net10.0 Android/iOS and the full test run. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c6d279adf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…at/dotnet10-maui-sample-v2 # Conflicts: # global.json
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cafa9b1ca4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to feat/dotnet10-maui-sample-v2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61a0347fab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abf24aaa67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to feat/dotnet10-maui-sample-v2
…at/dotnet10-maui-sample-v2 # Conflicts: # src/Mobile.BuildTools.AppManifests/Mobile.BuildTools.AppManifests.csproj # src/Mobile.BuildTools.AppManifests/Mobile.BuildTools.AppManifests.targets
The setup-msbuild action provides MSBuild 17.14, which can't load the .NET 10 SDK (requires MSBuild 18+). The hosted .NET 10 SDK already ships with its own MSBuild 18, so invoking the sample restore/build through 'dotnet restore' / 'dotnet build' picks up the correct toolchain.
|
I cleaned up a few stale review notes. The remaining Codex review entries are GitHub’s submitted review records, so I’m leaving them for traceability. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f65c02fbcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f65c02f to
fd11d26
Compare
…at/dotnet10-maui-sample-v2 # Conflicts: # .github/workflows/pr.yml # global.json
c8e8ff1 to
ee68e52
Compare
1 participant
Cleanup note: I removed stale bot noise and inline codex comments, and rewrote the Dan-authored review note to a natural form. Remaining
### 💡 Codex Reviewentries are submitted bot records and can’t be edited/deleted through GitHub API, so I left them.