Skip to content

Fix Codex launch planner shutdown ordering#395

Merged
danshapiro merged 1 commit into
mainfrom
fix-launch-planner-shutdown
Jun 7, 2026
Merged

Fix Codex launch planner shutdown ordering#395
danshapiro merged 1 commit into
mainfrom
fix-launch-planner-shutdown

Conversation

@danshapiro

Copy link
Copy Markdown
Owner

Summary

  • Start Codex runtime teardown concurrently with proxy close during launch-planner sidecar shutdown.
  • Add a proxy factory seam so launch-planner unit tests do not depend on real WebSocket proxy close timing.
  • Add deterministic coverage for slow proxy close during planner shutdown.

Verification

  • npm run test:vitest -- test/unit/server/coding-cli/codex-app-server/launch-planner.test.ts test/unit/server/coding-cli/codex-app-server/remote-proxy.test.ts test/unit/server/coding-cli/codex-app-server/runtime.test.ts --run
  • npm run check

@danshapiro danshapiro merged commit dfa1082 into main Jun 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants