Keep the clicked row visible when the diff pane opens over it - #85
Merged
Conversation
Selecting a commit or branch near the bottom of the Graph opens the diff pane under the stage — and the shrunk canvas swallowed the very thing that was just clicked. Arm a one-shot reveal on selection: the pane-opening resize consumes it and pans vertically just enough to keep the row's label, nodes and caption above the fold — never a recenter or horizontal jump, and it expires two frames later so splitter drags and window resizes stay entirely user-driven.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking a branch label (or commit) near the bottom of the Graph opens the diff pane under the stage — and the shrunk canvas swallowed the very thing that was just clicked. The selection ended up hidden behind the pane.
Fix
Arm a one-shot reveal when the selection changes: the resize the opening pane triggers consumes it and pans vertically, just enough to keep the clicked row — label pill, nodes and caption — above the fold.
revealRowDy(view, viewportHeight, row)ingeometry.ts(unit-tested);GraphCanvas.tsxwires it into the existing ResizeObserver.Validation
lint,typecheck, fullbun testsuite green (6 new tests forrevealRowDy).🤖 Generated with Claude Code