Let the stash review dialog scale with large windows - #83
Merged
Conversation
The dialog was hard-capped at 1180x760, leaving big screens full of dead space while file names and diffs stayed cramped. Size it relative to the viewport (94vw x 90vh) so it grows with the window, with generous caps so it stays a centered dialog on very large displays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stash review dialog was hard-capped at 1180×760px. On small windows the UX was fine, but on large screens the dialog stopped growing while the window kept going — plenty of free space around it, yet file names stayed truncated and the split diff cramped.
Fix
Size the dialog relative to the viewport instead:
It now grows with the window, so big screens get full file paths and a wide split diff. The caps only kick in on very large displays, where an edge-to-edge dialog reads worse than a generous centered one.
Verified
Drove the real app over CDP (playwright-cli) with a multi-file stash and screenshotted the dialog at 2400×1300 (fills the window, full paths visible) and 1200×800 (unchanged comfortable inset). Lint, typecheck and tests all green.
🤖 Generated with Claude Code