You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Adopt the Binary Ninja exporter from mcrit-plugin as smda.binja #356
Recording a decision taken on familiary/mcrit-plugin#16 so it is not lost with the session that made it.
The decision
The Binary Ninja SMDA exporter moves upstream into SMDA, rather than staying in the plugin. One of the five design questions settled on familiary/mcrit-plugin#16; the coupling this creates was weighed and accepted.
mcrit_plugin/binja/BinjaSmdaInterface.py (143 lines) becomes smda.binja, mirroring the smda.ida package that already holds IdaInterface.py, IdaExporter.py, IdaDomainInterface.py and IdaIdapythonInterface.py. The precedent for a disassembler-frontend exporter living in SMDA is therefore already set, and this is the second one rather than a new pattern.
Why upstream
An exporter that produces SMDA reports is versioned by SMDA's report format, not by the plugin's release cadence. Keeping it in the plugin means the format and its producer move on separate schedules, which is the same split that made the smda.ida exporter worth having here in the first place.
Not urgent, and not a blocker
The file currently lives on the mcrit-plugin side in familiary/mcrit-plugin#17 (draft), not on main. That PR lands at the repository's org move and does not wait on this issue. The move upstream happens afterwards.
Worth settling when it is picked up
Packaging.smda.ida has an ida = ["ida-domain>=0.5.0"] extra. Binary Ninja's Python API is installed from the application rather than from PyPI, so a binja extra cannot be the same shape. It may be that the import stays lazy and there is no extra at all.
The agreement metric.scripts/common/compare_smda_reports.py in mcrit-plugin reports IDA-vs-Binja agreement, currently 97.8% on a single small PE. Transforming the plugin into a multi-backend structure familiary/mcrit-plugin#16 settled that this is advisory and not a release gate, on the grounds that tool output cannot be influenced enough for a threshold to be enforceable. If the comparison script comes upstream with the exporter, it should arrive carrying that status explicitly.
Those agreement numbers rest on one binary. Widening the sample is tracked on the plugin side and is data-gathering, not a blocker for either move.
Activity
feat: add Binary Ninja exporter as smda.binja
feat(binja): add Binary Ninja exporter as smda.binja (danielplohmann#357