Skip to content

Promote the release workflow to a reusable workflow_call #355

Open

Description

@danielplohmann

Split out of #342, which is closed as a decision record. This is the one question in it that is still open.

The question

#342 said the workflow would be "written as a plain workflow here first; promoted to a reusable workflow_call once purepdb and mcrit adopt it, so there is one thing to pin and fix rather than three copies drifting."

purepdb has adopted it and released 0.6.0 through it. mcrit's port is open as familiary/mcrit#193. So the condition for asking the question is now essentially met.

Why it is worth asking rather than assuming

The copies have already started drifting, and this is the evidence, not a prediction:

Against

workflow_call costs indirection at the point where a release fails, which is the worst moment to be reading two files. The repositories are also not uniform: picblocks and mcrit-plugin release something other than a PyPI package, and mcritweb has no pyproject.toml on master yet.

A middle option worth costing: promote only the parts that are genuinely identical (the tag/version guard and the changelog extraction) and leave the publish and release jobs inline per repository.

Decide on

Whether it happens at all, and if so whether it is the whole workflow or only the guard script, and which repository hosts the reusable file.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions