Repository navigation
Say which tags can be rehearsed, and which cannot - #63
Merged
Merged
Conversation
"Choosing a tag as the ref" is true only of a tag cut after the workflow existed. A manual run resolves the workflow file, and checks out the guard script it calls, from the ref it is given, so v0.5.0 and earlier carry neither and fail in a way that does not name the cause. Verified against this repository: `git ls-tree v0.5.0 .github/workflows/` lists the old release.yml and no publish-release.yml, and no scripts/ at all. The same property is worth stating as the reassurance it also is: those three tags cannot trigger a publish if one is ever re-pushed. Also records how to rehearse a version before it ships, which the required reviewer on the `pypi` environment is what makes possible: the tag push parks the real run at the publish job, the rehearsal runs from the same tag while it waits, and the decision to approve or reject comes after. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASING.mdtold a maintainer to rehearse by "choosing a tag as the ref", without saying that only a tag cut after #59 can be one.A
workflow_dispatchrun resolves the workflow file from the ref it is given, and the verify job then checks out that same ref to runrelease_guard.py. Neither exists on a tag from before the workflow landed, so a rehearsal fromv0.5.0fails without naming the cause. I found this the useful way, by recommending exactly that as the way to seed TestPyPI.Verified against this repository:
git ls-tree -r v0.5.0 .github/workflows/listsci.yml,fuzz.yml,release.ymlandvalidate.yml— nopublish-release.yml, and noscripts/directory for the guard.The section now also records two things that follow from the same property:
pypienvironment holds at the publish job; the rehearsal runs from the same tag while it waits, and approve-or-reject comes after. Rejecting leaves the version number unused.Docs only — no entry required by the
Changelogcheck, which fires onpurepdb/andpyproject.toml.🤖 Generated with Claude Code