feat: allow editing an existing change's title (change 0461) - #347
Merged
danielhanold merged 10 commits intoSep 28, 2026
Merged
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-28-0461-allow-editing-an-existing-change-s-title.md
…ontrol titles (change 0461)
… a valid revise (change 0461)
…pec's backlink (change 0461)
…facts (change 0461, review fix-1) Finding (important): changeGroomOp.Plan accepted a title on a proposed change that still carries branch:/plan:/results: (a record deferred from in-progress and later revived keeps them). Those artifacts' backlinks embed the title and are identity-checked downstream (backlinkTargets -> backlink-mismatch on attach; verifyImplementedResults -> results-identity-broken on mark-implemented), so the retitle silently broke the later build. Plan now refuses such a request with the new typed finding code not-retitleable (FCNotRetitleable, registered in AllFindingCodes in sorted order) and writes nothing. A title equal to the current one is no retitle and still passes. Mutation-tested: dropping the guard, dropping its title-equality clause, and dropping the registry entry each redden a test.
…escape U+2028/U+2029 test literals (change 0461, review fix) - Minor 1: spec-backlink-missing message named `artifact backlink`, which stamps a feature-worktree file; the remedy is a spec-body revise with spec_markdown + spec_version + title. - Minor 2: TestValidateTitle separator cases used raw invisible characters; use escaped Go literals.
danielhanold
deleted the
feat/allow-editing-an-existing-change-s-title
branch
September 28, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↩ Change 0461 — Allow editing an existing change's title (https://github.com/danielhanold/docket/blob/docket/docs/changes/active/0461-allow-editing-an-existing-change-s-title.md)
Summary
change.groomaccepts an optionaltitleon the spec, trivial, revise, and rearm outcomes.abstainrefuses it withinvalid-title, and a request carrying only a title is a valid revise.title:andupdated:through the writer (ADR-0071), re-renders the## Artifactsblock and the board, and re-stamps only the linked spec'sdocket:backlinkblock.branch:never change.change.createandchange.groomshare onevalidateTitle: a line break or control character isinvalid-title, and whitespace-only staysempty-title.proposedchange that still carriesbranch:,plan:, orresults:(deferred, then revived) is refused asnot-retitleable.|and flatten line breaks.docket-groom-nextskill now points groomers attitle. A prose-contract sentinel covers that, and the embedded mirror is regenerated.internal/repoguard/budgets_test.go).Review (docket-review-deep; the rung went up one step because the diff exceeds 1500 lines)
spec-backlink-missingmessage named the wrong remedySuite note: the final run printed
SERIAL CONFIRMED OVER BUDGETfortests/test_go_integration_app_rebaserecovery.sh(63s solo against a 60s threshold). This change doesn't touch that test, and it was already on a parallel-overrun streak before this branch. I'm reporting it as follow-up work.Results: docs/results/2026-09-28-allow-editing-an-existing-change-s-title-results.md
command: go run ./cmd/docket development test
result: green
head_sha: b0ee6bf
ran_at: 2026-09-28T21:26:05Z