chore: close the temp-dir fixture guard's remaining gaps (change 0462) - #343
Merged
danielhanold merged 7 commits intoSep 27, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-27-close-the-temp-dir-fixture-guard-s-remaining-gaps-internal-c.md
…pDir (change 0462)
…k justified sites (change 0462)
…e repo (change 0462)
…e next line's MkdirTemp (change 0462, review finding: line-above exemption ignores trailing markers) The line-above exemption in mkdirTempViolations now counts only a standalone marker (first non-whitespace token on its line); a marker trailing code still exempts its own line. Adds a TestMkdirTempViolations case for a trailing marker followed by an unmarked call.
….github (change 0462, post-review follow-up) A guard run from the main checkout walked .docket/ and the local harness installs (.claude, .codex, .cursor, ...). Prune any dot-directory at any depth; .github is the one tracked hidden directory and stays in.
danielhanold
deleted the
chore/close-the-temp-dir-fixture-guard-s-remaining-gaps-internal-c
branch
September 27, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↩ Change 0462 — Close the temp-dir fixture guard's remaining gaps (internal/cli gateTempDir, scan-root removal)
Summary
internal/cli/gate_test.go's privategateTempDir(built onos.MkdirTemp). All 22 call sites now usetestsupport.TempDir(t).TestRealProcessPackagesUseFixtureTempDirnow also bans executable<ident>.MkdirTemp(calls in real-process test packages. A call is allowed only with a// tempdir-exempt: <reason>marker that has a non-empty reason. The marker can be on the same line, or alone on the line directly above. It is read from raw bytes, and the call is matched on the masked view.TestMainbinary builds.sync.Onceprocess-lifetime dirs./tmpalias test.internal/app/gate_drive_test.gorunroot, is converted to the fixture instead. It is a per-test dir.scanRootswith the sharedrepoguard.MaintainedFileswhole-repo walk. TherealProcFloorspopulation floors stay.Verification
cmdexcluded from the walk, andinternalexcluded.Review (docket-review-standard)
MkdirTempon the next linePost-review follow-up (8f7cbc1)
repoguard.MaintainedFilesnow prunes every hidden directory at any depth except.github/, the one tracked hidden directory. When a guard runs from the primary checkout, it no longer walks.docket/or the local harness installs (.claude/,.codex/,.cursor/, ...). The rule also covers the former.git/.worktreesexclusions.TestMaintainedFilesIncludesAndExcludespins both directions and was mutation-tested. The full suite passed (54/54) at 8f7cbc1. The build-evidence block below still certifies the earlier head, so finalize re-gates this one.command: go run ./cmd/docket development test
result: green
head_sha: 8f7cbc1
ran_at: 2026-09-27T20:53:51Z