feat: typed auto_groomable/branch_prefix at create; typed auto-groom abstain/rearm (change 0382) - #342
Merged
danielhanold merged 12 commits intoSep 27, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-27-0382-typed-auto-groomable-branch-prefix-and-abstain-rearm.md
…hen set (change 0382)
…branch_prefix (change 0382)
…try, and the board atomically (change 0382)
…e-renders the board (change 0382)
…gh change.create (change 0382)
…and groom-next (change 0382)
…groomable is a warning (change 0382 review minors 1-2) Review minor 1: the board's auto-groom-blocked cell (hasHeading) matched fenced heading-shaped lines while change.groom rearm's section scanner skipped them, so a fenced example could show 'needs you' with no typed op able to clear it. hasHeading now skips fenced code for all presence markers, matching scanTopHeadings. Review minor 2: a non-boolean auto_groomable raised an error-severity field-malformed that would block pr.publish/finalize on previously valid records; it is now a warning and the value stays unset.
…; groom-next documents the re-arm exit (change 0382, findings 3+4)
danielhanold
force-pushed
the
feat/changecreaterequest-typed-auto-groomable-branch-prefix-scalars
branch
from
September 27, 2026 19:49
19c22c9 to
603123b
Compare
danielhanold
deleted the
feat/changecreaterequest-typed-auto-groomable-branch-prefix-scalars
branch
September 27, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docket change createaccepts typedauto_groomable(tri-state) andbranch_prefix(normalized in Go bydomain.NormalizeBranchPrefix; invalid values refused asinvalid-branch_prefix).docket change groomgainsabstainandrearmoutcomes that write the flag, the dated## Auto-groom blockedentry (or remove it), and the board atomically.Results: docs/results/2026-09-27-changecreaterequest-typed-auto-groomable-branch-prefix-scalars-results.md
Review
Rung: docket-review-deep (default standard, bumped one step for a >1500-line diff). 4 minor findings, 0 blocker, 0 important.
auto_groomablebecame an error-severity finding blocking publish/finalizeBuild evidence
command: go run ./cmd/docket development test
result: green
head_sha: 603123b
ran_at: 2026-09-27T19:49:10Z