chore: extend testsupport temp-dir fixture and repoguard to cmd/ (change 0398) - #341
Merged
danielhanold merged 4 commits intoSep 27, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-27-extend-the-testsupport-temp-dir-fixture-and-repoguard-to-cmd.md
…rocess packages (change 0398)
…xture (change 0398)
danielhanold
deleted the
chore/extend-the-testsupport-temp-dir-fixture-and-repoguard-to-cmd
branch
September 27, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends change 0373's temp-dir fixture guard (
TestRealProcessPackagesUseFixtureTempDir) frominternal/tointernal/+cmd/, converts the 12 baret.TempDir()sites incmd/docketandcmd/releasepkgtotestsupport.TempDir(t), and deletes the privategateTempDirhelper incmd/docket/gate_cli_test.go.cmd/docketpopulation floor keeps a brokencmd/walk from passing vacuously.cmdfrom the roots reddens the floor.Results: docs/results/2026-09-27-extend-the-testsupport-temp-dir-fixture-and-repoguard-to-cmd-results.md
Review
Rung: docket-review-standard. Both tasks were built at the standard profile, and the diff is under 1500 lines. Outcome: clean, no findings.
command: go run ./cmd/docket development test
result: green
head_sha: 9c2acb4
ran_at: 2026-09-27T11:37:58Z
The evidence head is the results-commit head that the full suite ran on.