fix(reposetup): stop flagging writer-quoted frontmatter scalars as manual review (change 0447) - #340
Merged
danielhanold merged 5 commits intoSep 27, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-27-repository-check-flags-docket-s-own-single-quoted-frontmatte.md
danielhanold
force-pushed
the
fix/repository-check-flags-docket-s-own-single-quoted-frontmatte
branch
from
September 27, 2026 17:50
f322a58 to
9b2adbb
Compare
danielhanold
deleted the
fix/repository-check-flags-docket-s-own-single-quoted-frontmatte
branch
September 27, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docket repository checkreported every correctly quoted string field (slug: 'x',title: '…',type: 'fix') as afrontmatter-manual-reviewerror, because the checker compared the raw quoted bytes against the decoded value. That was 921 findings on the live corpus, with no way to clear them.What changed
wellFormedQuotedStringhelper ininternal/reposetup/repair.godecides on the parsed YAML node: exactly one string scalar, single- or double-quoted, no tag or anchor, and nothing after it (a second decode must hit EOF).planQuotereturns no finding for such tokens.yes,true, unquoted:) and malformed quoting are still reported, unchanged.change.create→ zero repair findings test. Each guard was mutation-checked.Verification
frontmatter-manual-review921 → 0; other finding families unchanged (artifact-links-stale275,drop-terminal-claimed-at241).Deviation from spec: the helper also requires end-of-input, since a single YAML decode silently accepts trailing content like
'a' b. Stricter than specified.command: go run ./cmd/docket development test
result: green
head_sha: 9b2adbb
ran_at: 2026-09-27T17:50:03Z