Skip to content

docs(skills): document the record-invalid refusal in finalize and implement-next (change 0455) - #339

Merged
danielhanold merged 5 commits into
mainfrom
docs/document-finalize-s-record-invalid-reason-in-the-docket-fina
Sep 27, 2026
Merged

danielhanold merged 5 commits into
mainfrom
docs/document-finalize-s-record-invalid-reason-in-the-docket-fina

Conversation

@danielhanold

Copy link
Copy Markdown
Owner

↩ Change 0455 — Document finalize's record-invalid reason in the docket-finalize-change skill

Documents the record-invalid refusal (added by change 0449 / ADR-0127) in the two skills that drive the affected operations:

  • docket-finalize-change step 8: finalize.merge refuses invalid-state/blocked with reason record-invalid before any merge call when the change, a depends_on target, a stack ancestor, or another record carrying its id fails validation (associative links are never checked). Remedy: repair exactly the records named in findings, then re-run. Explains that a PR merged outside docket with a defective record in scope reports record-invalid rather than already-merged by design.
  • docket-implement-next "Publish the PR": pr.publish refuses record-invalid (invalid-state) under the same scope; repair and re-publish.

Skill word budgets bumped to exact counts; embedded asset bundle regenerated.

The spec's gofmt fix for internal/githubcli/comment_integration_test.go was a no-op: the file is already formatted for the go.mod-pinned toolchain (21f8511); only the older PATH gofmt flags it.

Review (lean rung): 2 minor findings, both fixed in 2f77444 (envelope result named in finalize; duplicate-id carriers in scope).

Results: docs/results/2026-09-27-document-finalize-s-record-invalid-reason-in-the-docket-fina-results.md

command: go run ./cmd/docket development test
result: green
head_sha: 56a7743
ran_at: 2026-09-27T10:35:09Z

@danielhanold
danielhanold merged commit ab1a9a1 into main Sep 27, 2026
7 checks passed
@danielhanold
danielhanold deleted the docs/document-finalize-s-record-invalid-reason-in-the-docket-fina branch September 27, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant