docs(skills): document the record-invalid refusal in finalize and implement-next (change 0455) - #339
Merged
danielhanold merged 5 commits intoSep 27, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-27-document-finalize-s-record-invalid-reason-in-the-docket-fina.md
…ize step 8 (change 0455)
…-next (change 0455)
… (change 0455 review)
danielhanold
deleted the
docs/document-finalize-s-record-invalid-reason-in-the-docket-fina
branch
September 27, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
record-invalidrefusal (added by change 0449 / ADR-0127) in the two skills that drive the affected operations:docket-finalize-changestep 8:finalize.mergerefusesinvalid-state/blockedwith reasonrecord-invalidbefore any merge call when the change, adepends_ontarget, a stack ancestor, or another record carrying its id fails validation (associative links are never checked). Remedy: repair exactly the records named infindings, then re-run. Explains that a PR merged outside docket with a defective record in scope reportsrecord-invalidrather thanalready-mergedby design.docket-implement-next"Publish the PR":pr.publishrefusesrecord-invalid(invalid-state) under the same scope; repair and re-publish.Skill word budgets bumped to exact counts; embedded asset bundle regenerated.
The spec's
gofmtfix forinternal/githubcli/comment_integration_test.gowas a no-op: the file is already formatted for the go.mod-pinned toolchain (21f8511); only the older PATH gofmt flags it.Review (lean rung): 2 minor findings, both fixed in 2f77444 (envelope result named in finalize; duplicate-id carriers in scope).
Results:
docs/results/2026-09-27-document-finalize-s-record-invalid-reason-in-the-docket-fina-results.mdcommand: go run ./cmd/docket development test
result: green
head_sha: 56a7743
ran_at: 2026-09-27T10:35:09Z