fix(app): same-day re-attach of an artifact is a no-op (change 0458) - #335
Merged
danielhanold merged 5 commits intoSep 25, 2026
Merged
danielhanold merged 5 commits into
danielhanold merged 5 commits into
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-25-attach-same-day-reattach-noop-plan.md
danielhanold
deleted the
fix/attach-refuses-a-same-path-same-day-re-attach-with-verify-de
branch
September 25, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-attaching the same plan or results path to a change on the same day failed with
invalid-stateatverify-delta("a declared path is not an actual change").changeAttachOp.Plannow declares the change record only when its bytes actually change, mirroring the existing guard inchange_groom.go. A same-path same-day re-attach now returnsno-opwith no commit.Tests
TestChangeAttachIdenticalReattachIsNoOp(attach-plan and attach-results, inline board on): red before the fix, green after.Review
docket-review-lean (all tasks routed economy; small diff): clean, no findings.
command: go run ./cmd/docket development test
result: green
head_sha: bcb2603
ran_at: 2026-09-25T14:32:55Z