chore: typed change.unblock and change.revive operations (change 0450) - #334
Merged
danielhanold merged 8 commits intoSep 25, 2026
Merged
danielhanold merged 8 commits into
danielhanold merged 8 commits into
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-25-typed-change-unblock-operation-to-reverse-change-block.md
…hange 0450) Review finding (important): the spec's Testing section requires one applied unblock and one applied revive through the real engine, asserting the receipt, commit subject, and board row; the applied tests used recordingEngine and revive never ran through the real engine. Adds TestIntegrationChangeRuntimeDeferThenRevive (defer then revive via the real engine: receipt identity, committed revision == tip, subject 'change 0005 → proposed', BOARD.md row under Proposed with no Deferred section, board matches a fresh render) and adds the commit-subject and BOARD.md row assertions to the unblock step of TestIntegrationChangeRuntimeUnblockThenResumeHalted.
danielhanold
deleted the
chore/typed-change-unblock-operation-to-reverse-change-block
branch
September 25, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↩ Change 0450 — Typed change.unblock operation to reverse change.block
Summary
Adds the missing typed inverses of
change.blockandchange.defer:docket change unblock(change.unblock):blocked→in-progress, clearsblocked_by.docket change revive(change.revive):deferred→proposed; keeps## Why deferred,branch:andclaimed_at:.Both expose the existing
domain.Unblockanddomain.Revivetransitions through the existingexecuteChangeLifecycledriver, so each is one exact-version metadata commit that also re-renders the artifacts block and the board. A change in any other status is refused withinvalid-stateand nothing is written. The commands are wired into the CLI, the schema registry and the asset-independent set. The docket-convention lifecycle rules now name them instead of the hand edit. The halt → block → unblock → resume-halted path (the change 0444 incident) has a real-engine regression test.Review
Reviewer rung: standard (highest task profile standard; diff under 1500 lines).
command: go run ./cmd/docket development test
result: green
head_sha: 098a277
ran_at: 2026-09-25T11:47:09Z
Budget report: several parallel
BUDGET WATCHlines (screening only); noSERIAL CONFIRMED OVER BUDGET.