fix: whole-repository status survives an unrelated change's invalid branch name (0454) - #331
Merged
danielhanold merged 9 commits intoSep 25, 2026
Conversation
Docket-Plan-Path: docs/superpowers/plans/2026-09-24-whole-repository-status-must-not-fail-on-an-unrelated-change.md
…t ValidBranchName (change 0454)
…a state-valid remedy (change 0454)
…k branch (change 0454)
danielhanold
deleted the
fix/whole-repository-status-must-not-fail-on-an-unrelated-change
branch
September 25, 2026 05:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docket status,maintenance.preflight, and automaticcontext.implementationselection no longer fail as a whole withexternal-failedwhen an unrelated change records an invalidbranch:name.check-ref-formatrules and is exported asgitcli.ValidBranchName.stackBranches) skips names that fail that check, so they count as absent. A child stacked on such a parent readsstack-base-unresolved.statusreports an error-severitybranch-malformedfinding on each displayed active change whose branch name is invalid. Its remedy depends on the record: a filled-inrepair-identity --adopt-pr-headcommand if the record has a PR, otherwise a hand edit followed byrepository migrate.recordedBranchdelegates to the same check, so that repair works for names likefeat/a:b.Status.A well-formed name whose probe fails for a real reason still fails the read. Named probes (
stackBranchesFor) are unchanged.Review
Rung: docket-review-standard (every task routed to standard, and the diff is under 1500 lines). No findings.
command: go run ./cmd/docket development test
result: green
head_sha: 5540fa7
ran_at: 2026-09-24T21:16:16Z