docs: replace Zuplo sponsorship with SerpApi - #1106
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The current changes introduce a few correctness/accessibility/security issues (invalid SVG gradient references, target="_blank" missing noreferrer, and invalid spacer <img> tags / localization consistency in README_JA) that should be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates Huma’s documentation and repository READMEs to replace Zuplo sponsor placements with SerpApi, including a new docs-site sponsor banner and SerpApi brand assets, while removing the remaining Zuplo promotional resource.
Changes:
- Replace sponsor blocks in
README.mdandREADME_JA.mdwith SerpApi placement + tracking link. - Update MkDocs announce banner to a new SerpApi sponsor banner component and add corresponding CSS.
- Remove the Zuplo external resource link from the client SDK tutorial and add SerpApi SVG asset.
File summaries
| File | Description |
|---|---|
| README.md | Swaps the sponsor block to SerpApi and updates link + banner image usage. |
| README_JA.md | Swaps the sponsor block to SerpApi in the Japanese README. |
| docs/overrides/main.html | Replaces the announce banner with a new SerpApi sponsor banner markup. |
| docs/docs/tutorial/client-sdks.md | Removes Zuplo “External Resources” section from the tutorial. |
| docs/docs/stylesheets/extra.css | Adds styling for the new sponsor banner component. |
| docs/docs/serpapi-white.svg | Adds the SerpApi logo asset for the docs sponsor banner. |
Review details
- Files reviewed: 5/8 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Our API Gateway allows you to secure your API, scale it globally, generate documentation from your OpenAPI, and monetize your users. | ||
| </p> | ||
| <a href="https://zuplo.link/huma-gh ">Start for Free</a> | ||
| <img width="1000" height="0" /> |
| <h3>SerpApi: Web Search API</h3> | ||
| <p> | ||
| 当社のAPI Gatewayは、APIのセキュリティ強化、グローバルスケール、OpenAPIからのドキュメント生成、ユーザーの収益化を支援します。 | ||
| Access Google Search, Maps, Shopping, and other search engine data with a simple API by SerpApi. | ||
| </p> | ||
| <a href="https://zuplo.link/huma-gh">無料で始める</a> | ||
| <a href="https://serpapi.com/?utm_source=huma">Learn more</a> |
| @@ -78,16 +78,14 @@ | |||
|
|
|||
| <div> | |||
| <img width="1000" height="0" /> | |||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 23 23
Lines 4988 4988
=======================================
Hits 4649 4649
Misses 272 272
Partials 67 67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Addressed the review feedback in bd42564: removed the invalid spacer images, localized the Japanese sponsor copy and CTA, added noreferrer to the outbound banner link, and replaced the SVG's dangling gradient references with explicit white fills. The SVG validates with xmllint and the strict MkDocs build passes. |
Replaces the former Zuplo sponsor placements with SerpApi across the Huma docs site and README files. Adds the official SerpApi assets and project-specific tracking link, and removes the remaining Zuplo promotional resource.\n\nValidation: strict MkDocs build.