Cache the surface ring's drop shadow to cut per-frame GPU cost - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The surface ring carries a
DropShadowEffectwithBlurRadius=32andRenderingBias="Quality", and it sits underneath every animating element in the menu. WPF re-evaluates the multi-pass Gaussian blur whenever the scene recomposes, so the blur runs during hover/press transitions, drag-to-reorder, and the window fades, which is exactly when the per-frame budget matters.This wraps the shadowed ring in a container with a
BitmapCache(rendered at the current DPI scale so it stays crisp under display scaling), so the blur is rasterized once per menu build and then composited as a texture on every subsequent frame.Notes
RenderingBiasstays atQuality: with the result cached, the high-quality blur only costs once per rebuild instead of once per frame, so there's no reason to trade it away.