Fix automatic countdown being skewed by the UTC offset - #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default countdown display (empty format, the "Automatic" preset) was wrong by the machine's UTC offset for every non-UTC user. On UTC-6, a target of exactly now showed "6 hours from now".
Cause:
nowDateTimeis a local wall-clock value withKind=Unspecified. Humanizer converts the comparison date into the frame implied byutcDate(ToLocalTime()forfalse), and that conversion shifts Unspecified values by the UTC offset.Fix: pin the comparison date's Kind to
Localso the conversion is a no-op. Verified empirically against the built exe on a UTC-6 machine: