fix: preserve response cookie intent#144
Merged
Merged
Conversation
b1397f1 to
a2f9587
Compare
a2f9587 to
46a7404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TangoHeaders.setCookie()replacement-aware for helper-managed cookies with the same name, domain, and pathgetSetCookie()so response cookies can be transferred as separateSet-CookielinesTangoResponse.toWebResponse()and Express response forwardingValidation
pnpm exec prettier --check .changeset/cookie-intent-semantics.md packages/core/src/http/TangoHeaders.ts packages/core/src/http/TangoResponse.ts packages/core/src/http/tests/TangoHeaders.test.ts packages/core/src/http/tests/TangoResponse.test.ts packages/adapters/express/src/adapter/ExpressAdapter.ts packages/adapters/express/src/adapter/tests/ExpressAdapter.test.tspnpm --filter @danceroutine/tango-core testpnpm --filter @danceroutine/tango-adapters-express testpnpm --filter @danceroutine/tango-adapters-next testpnpm --filter @danceroutine/tango-adapters-nuxt testpnpm changeset status --since=origin/main--ignoreDeprecations 5.0for core and Express prod/test configsTypecheck note
The raw package typecheck commands currently fail before source diagnostics because this checkout uses TypeScript 5.9.3 while
tsconfig.base.jsonhasignoreDeprecations: "6.0". The source-level checks pass when overriding that setting to5.0.