Skip to content

fix: preserve response cookie intent#144

Merged
danceroutine merged 4 commits into
mainfrom
fix/cookie-intent-semantics
Jun 5, 2026
Merged

fix: preserve response cookie intent#144
danceroutine merged 4 commits into
mainfrom
fix/cookie-intent-semantics

Conversation

@danceroutine

Copy link
Copy Markdown
Owner

Summary

  • make TangoHeaders.setCookie() replacement-aware for helper-managed cookies with the same name, domain, and path
  • add getSetCookie() so response cookies can be transferred as separate Set-Cookie lines
  • preserve multiple cookie lines through TangoResponse.toWebResponse() and Express response forwarding
  • add a patch changeset for the core and Express adapter behavior fix

Validation

  • pnpm exec prettier --check .changeset/cookie-intent-semantics.md packages/core/src/http/TangoHeaders.ts packages/core/src/http/TangoResponse.ts packages/core/src/http/tests/TangoHeaders.test.ts packages/core/src/http/tests/TangoResponse.test.ts packages/adapters/express/src/adapter/ExpressAdapter.ts packages/adapters/express/src/adapter/tests/ExpressAdapter.test.ts
  • pnpm --filter @danceroutine/tango-core test
  • pnpm --filter @danceroutine/tango-adapters-express test
  • pnpm --filter @danceroutine/tango-adapters-next test
  • pnpm --filter @danceroutine/tango-adapters-nuxt test
  • pnpm changeset status --since=origin/main
  • source-level typechecks passed with --ignoreDeprecations 5.0 for core and Express prod/test configs

Typecheck note

The raw package typecheck commands currently fail before source diagnostics because this checkout uses TypeScript 5.9.3 while tsconfig.base.json has ignoreDeprecations: "6.0". The source-level checks pass when overriding that setting to 5.0.

@danceroutine danceroutine force-pushed the fix/cookie-intent-semantics branch from b1397f1 to a2f9587 Compare June 5, 2026 15:32
@danceroutine danceroutine force-pushed the fix/cookie-intent-semantics branch from a2f9587 to 46a7404 Compare June 5, 2026 15:38
@danceroutine danceroutine enabled auto-merge (squash) June 5, 2026 15:41
@danceroutine danceroutine merged commit fa66b73 into main Jun 5, 2026
8 checks passed
@danceroutine danceroutine deleted the fix/cookie-intent-semantics branch June 5, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant