fix: close migration CLI db clients on failure paths#143
Merged
Conversation
Wrap migrate and status handlers in try/finally so dbClient.close() runs when runner.apply() or runner.status() throws, matching connectAndIntrospect().
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9183c8dd53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Log close failures instead of letting them replace the primary migrate or status error. Add changeset and regression tests for the dual-failure path.
State the migrate/status failure behavior in outcome language and remove contrastive implementation phrasing from the patch note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrateandstatusCLI handlers intry/finallysodbClient.close()always runs, even whenrunner.apply()orrunner.status()throws.connectAndIntrospect()pattern in the same file.MigrationRunnerfailures and assert the CLI client is closed.Why
On failure paths (SQL errors, checksum mismatches, invalid migration modules), the CLI previously skipped
close()and could leak database connections.Test plan
pnpm --filter @danceroutine/tango-migrations testpnpm --filter @danceroutine/tango-migrations typecheck