Prevent unhandled promise rejections in LN invoice status checks#37
Draft
Copilot wants to merge 2 commits into
Draft
Prevent unhandled promise rejections in LN invoice status checks#37Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/damus-io/api/sessions/cb180abc-925e-4c61-a500-ba8d094f4f4a Co-authored-by: danieldaquino <24692108+danieldaquino@users.noreply.github.com>
Agent-Logs-Url: https://github.com/damus-io/api/sessions/cb180abc-925e-4c61-a500-ba8d094f4f4a Co-authored-by: danieldaquino <24692108+danieldaquino@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
danieldaquino
May 20, 2026 19:46
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service could terminate on
ERR_UNHANDLED_REJECTIONwhen LN invoice polling hit a rejected promise with anundefinedreason. This PR hardens invoice-status checking so failures are contained and converted into safe, non-crashing outcomes.Invoice wait flow hardening (
src/invoicing.js)check_invoice_is_paidto avoidnew Promise(async ...), which can leak unhandled rejections from the async executor..catch(() => undefined)and usedPromise.race(...)to return the first settled result.finallyto avoid stale timers.Regression coverage (
test/ln_flow.test.js)undefinedand asserts:check_invoice_is_paid(...)resolves toundefinedunhandledRejectionprocess event is emitted