Harden Noswhere translation response handling and add failure diagnostics#36
Merged
danieldaquino merged 3 commits intoMay 20, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/damus-io/api/sessions/30936094-ca55-465a-9ffa-c7f7bd2d4a58 Co-authored-by: danieldaquino <24692108+danieldaquino@users.noreply.github.com>
Agent-Logs-Url: https://github.com/damus-io/api/sessions/30936094-ca55-465a-9ffa-c7f7bd2d4a58 Co-authored-by: danieldaquino <24692108+danieldaquino@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with Noswhere translation API causing server crashes
Harden Noswhere translation response handling and add failure diagnostics
May 20, 2026
Collaborator
|
@copilot I still see this other issue: Please create a new PR to address that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed or empty responses from the Noswhere translation API could surface as unhandled JSON parse failures during language bootstrap and destabilize the server. This change hardens that path and adds enough response context to make production failures diagnosable.
Guard Noswhere JSON parsing
/langsand/translateresponses from raw text instead of assuming valid JSON.Improve production diagnostics
getting translation langs/translating)okx-noswhere-requestAdd focused regression coverage
/langsresponses to ensure bootstrap failures are contained and logged./translateresponses to ensure request ids and body snippets are surfaced.