Speed up geography helpers with pyproj#33
Open
scyrock wants to merge 1 commit into
Open
Conversation
dakk
requested changes
Jul 20, 2026
dakk
left a comment
dakk
left a comment
Owner
There was a problem hiding this comment.
Pretty awesome time improvements; anyway, the code you wrote in lossodromic (using the wsg84 geode) calculate the ortodromic distance, so a code switch is needed.
And you can switch lossodromic to ortodromic in router.py as well (indeed, ortodromic distance is the correct distance to be used, we were using lossodromic since was "faster" to calculate, and a good approximation for short distances).
Sorry for the delay, busy time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More details about the performance improvement and numerical validation are available in PR #32