Skip to content

simplify some Vector handling #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moritz-gross wants to merge 3 commits into
base: main
Choose a base branch
from
Open

simplify some Vector handling #828

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0ca213
simplify some Vector handling
moritz-gross Sep 26, 2026
d5fbcaf
undo changes in `is_structural`
moritz-gross Sep 26, 2026
bca88d9
Merge branch 'main' into refactor/simplify-Vector-handling
moritz-gross Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/braille.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2289,19 +2289,14 @@ fn handle_contractions(full_chars: &[char], start: usize, end: usize, mut result
}

fn init_patterns(contractions: &[Replacement]) -> RegexSet {
let mut vec: Vec<&str> = Vec::with_capacity(contractions.len());
for contraction in contractions {
vec.push(&contraction.pattern);
}
return RegexSet::new(&vec).unwrap();
let patterns = contractions.iter().map(|c| c.pattern.as_str());
return RegexSet::new(patterns).unwrap();
}

fn init_regex(contractions: &[Replacement]) -> Vec<Regex> {
let mut vec = Vec::with_capacity(contractions.len());
for contraction in contractions {
vec.push(Regex::new(&contraction.pattern).unwrap());
}
return vec;
return contractions.iter()
.map(|c| Regex::new(&c.pattern).unwrap())
.collect();
}
}

Expand Down
Loading