Set CRLF line endings for .rs and .yaml files - #804
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the issue of Codex introducing
LFendings while editing, while the rest of the repo usesCRLF.From what I've researched, the two ways to fix this problem: 1) using
.gitattributesto specify which format should be used while tracking in git and 2) using the.editorconfigfile that's supported by most IDEs to specify what should be used for editing files.The file
Rules/Languages/de/unicode.yamlis getting converted back to CRLF in this PR, none of its content is changed.@NSoiffer I'll go ahead and just merge this as I'm pretty sure this should be ok. If no, pls tell me if I misunderstand this topic and revert it.