ja: mark the reviewed navigation strings as verified - #778
Merged
Merged
Conversation
Lowercase `t:` means untranslated or unverified and uppercase `T:` means
translated and verified, so this is a review rather than bookkeeping. Each of
the twenty-three lines was read against the value the English source carries in
the same rule -- the value, not the `phrase(...)` hint, because those two can
disagree: move-cell-next says "no next column" under a hint that reads "no next
row", and the Japanese follows the value.
Nineteen lines were already right and only change case. Four were the odd one
out among their own siblings and are reworded as well:
最初の文字にズームイン -> 最初の文字までズームしました
the other two zoom reports in that same test are sentences
(ズームインを最大にしました, 文字までズームしました); this one was a bare
noun phrase and did not read as a report of where the zoom ended up.
現在のエントリを読む -> 現在のセルを読む
エントリ appears exactly once in the whole Japanese rule set. The rule
speaks 行 and 列 straight after it, and the sibling rule says 表, so セル is
the word these rules already use for the thing being read.
シンプル -> 簡易
the three navigation modes are spoken as <word> + モード, and 文字 and 拡張
are ordinary words while this one was a transliteration between them.
移動後の式の概要 -> 移動後に式の概要を読み上げる
the two states of one toggle: the other is the sentence
移動後に式を読み上げる, and this one did not say what would happen to it.
There is no Japanese appendix for navigation wording, unlike the ClearSpeak
terms, so those four are a judgement call and each one has a test.
audit-translations ja: untranslated 3415 -> 3392, which is exactly the number of
lines promoted; rule differences unchanged at 30; missing, extra and definition
counts unchanged at 0.
Tests: four in navigate.rs. Reaching the first-character branch needs Character
mode, so the helpers grew a mode argument; the sequence is the one
move_inside_leaves in src/navigate.rs uses -- ZoomInAll to the leaf, then one
more ZoomIn to step inside it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XzNYYoiVRzKGnDEWTJnuHh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
navigate.yamlstill had twenty-three Japanese strings sitting under lowercaset:. PerPythonScripts/audit_translations/README.md, lowercase means untranslated or unverified and uppercase means translated and verified, so promoting them is a claim about the reading rather than bookkeeping. Each line was read against the value the English source carries in the same rule — the value, not thephrase(...)hint, since those two can disagree:move-cell-nextsays"no next column"under a hint that reads'no next row', and the Japanese follows the value.Nineteen lines were already right and only change case. Four were the odd one out among their own siblings and are reworded as well. There is no Japanese appendix for navigation wording — unlike the ClearSpeak terms — so those four are a judgement call, and each one has a test:
say-commanddefault-read-celltoggle-mode-up/toggle-mode-down<word>+ モード, and 文字 and 拡張 are ordinary words while this one was a transliteration between themtoggle-speech-describeMeasurements
audit-translations ja, against this branch's merge base:The drop is exactly the number of lines promoted, and nothing structural moved.
Tests
Four in
tests/Languages/ja/navigate.rs, one per reworded string. Reaching the first-character branch needs Character mode, so the helpers grew a mode argument; the command sequence is the onemove_inside_leavesinsrc/navigate.rsuses —ZoomInAllto the leaf, then one moreZoomInto step inside it.To check that the tests hold the wording rather than merely passing, I pushed a branch that reverts those four readings and nothing else: exactly those four went red.