Skip to content

feat: expose live room activity status #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
idoshamun wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: expose live room activity status #3908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion __tests__/boot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ import { UserExperienceEducation } from '../src/entity/user/experiences/UserExpe
import * as betterAuthModule from '../src/betterAuth';
import { remoteConfig } from '../src/remoteConfig';
import { LiveRoom } from '../src/entity/LiveRoom';
import { LiveRoomStatus } from '../src/common/schema/liveRooms';
import { LiveRoomMode, LiveRoomStatus } from '../src/common/schema/liveRooms';

const flytingOrigin = 'http://flyting.test';
const flytingInternalKey = 'flyting-internal-key';

let app: FastifyInstance;
let con: DataSource;
Expand Down Expand Up @@ -220,6 +223,9 @@ jest.mock('../src/growthbook', () => ({
}));

beforeAll(async () => {
process.env.FLYTING_INTERNAL_KEY = flytingInternalKey;
process.env.FLYTING_ORIGIN = flytingOrigin;

con = await createOrGetConnection();
state = await initializeGraphQLTesting(() => new MockContext(con));
app = state.app;
Expand Down Expand Up @@ -274,6 +280,38 @@ describe('anonymous boot', () => {
expect(res.body.liveRooms).toEqual({ hasLive: true });
});

it('should indicate when community-moderated room activity is live', async () => {
await con.getRepository(LiveRoom).save({
id: '40ad3407-0d6a-4d95-98c2-bc5a3d7cf4d1',
hostId: '1',
topic: 'Community boot hint',
mode: LiveRoomMode.CommunityModerated,
status: LiveRoomStatus.Created,
});
const scope = nock(flytingOrigin)
.post('/internal/live-rooms/counts', {
roomIds: ['40ad3407-0d6a-4d95-98c2-bc5a3d7cf4d1'],
})
.matchHeader('x-flyting-internal-key', flytingInternalKey)
.reply(200, {
rooms: [
{
activityStatus: 'live',
roomId: '40ad3407-0d6a-4d95-98c2-bc5a3d7cf4d1',
participantCount: 3,
},
],
});

const res = await request(app.server)
.get(BASE_PATH)
.set('User-Agent', TEST_UA)
.expect(200);

expect(res.body.liveRooms).toEqual({ hasLive: true });
expect(scope.isDone()).toBe(true);
});

it('should reuse the cached live rooms boot hint', async () => {
const first = await request(app.server)
.get(BASE_PATH)
Expand Down
129 changes: 127 additions & 2 deletions __tests__/liveRooms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ import {
import { usersFixture } from './fixture/user';
import { User } from '../src/entity/user/User';
import { LiveRoomStatus } from '../src/common/schema/liveRooms';
import { deleteKeysByPattern } from '../src/redis';
import { deleteKeysByPattern, ioRedisPool } from '../src/redis';
import { postsFixture } from './fixture/post';
import { sourcesFixture } from './fixture/source';
import { LIVE_ROOM_POST_PROMOTION_SECONDS } from '../src/schema/liveRooms';
import { liveRoomParticipantCountCacheKey } from '../src/common/liveRoom/participantCount';

const {
mock: temporalMock,
Expand Down Expand Up @@ -125,6 +126,7 @@ describe('live rooms', () => {
topic
mode
status
activityStatus
participantCount
scheduledStart
description
Expand All @@ -151,6 +153,7 @@ describe('live rooms', () => {
topic
mode
status
activityStatus
participantCount
host {
id
Expand All @@ -167,6 +170,7 @@ describe('live rooms', () => {
topic
mode
status
activityStatus
participantCount
host {
id
Expand Down Expand Up @@ -195,6 +199,7 @@ describe('live rooms', () => {
topic
mode
status
activityStatus
participantCount
host {
id
Expand Down Expand Up @@ -405,6 +410,20 @@ describe('live rooms', () => {
})
.matchHeader('x-flyting-internal-key', flytingInternalKey)
.reply(200, { room: { roomId: 'ignored' } });
const countsScope = nock(flytingOrigin)
.post('/internal/live-rooms/counts', (body) => {
return Array.isArray(body.roomIds) && body.roomIds.length === 1;
})
.matchHeader('x-flyting-internal-key', flytingInternalKey)
.reply(200, (_uri, body: { roomIds: string[] }) => ({
rooms: [
{
activityStatus: 'pending',
roomId: body.roomIds[0],
participantCount: 0,
},
],
}));

const res = await client.mutate(CREATE_MUTATION, {
variables: {
Expand All @@ -422,7 +441,8 @@ describe('live rooms', () => {
topic: 'Community floor',
mode: 'community_moderated',
status: 'created',
participantCount: null,
activityStatus: 'pending',
participantCount: 0,
});

const room = await con.getRepository(LiveRoom).findOneByOrFail({
Expand All @@ -431,6 +451,7 @@ describe('live rooms', () => {

expect(room.mode).toBe('community_moderated');
expect(scope.isDone()).toBe(true);
expect(countsScope.isDone()).toBe(true);
});

it('rejects community-moderated live rooms without a minimum participant count', async () => {
Expand Down Expand Up @@ -720,6 +741,7 @@ describe('live rooms', () => {
topic: 'Live room',
mode: 'moderated',
status: 'live',
activityStatus: 'live',
participantCount: 7,
host: {
id: '2',
Expand All @@ -731,6 +753,77 @@ describe('live rooms', () => {
expect(scope.isDone()).toBe(true);
});

it('returns community-moderated rooms only when their activity is live', async () => {
await saveFixtures(con, LiveRoom, [
{
id: '33333333-b26e-44fb-b9f8-4c977b28a123',
hostId: '1',
topic: 'Pending community room',
mode: 'community_moderated',
status: LiveRoomStatus.Created,
createdAt: new Date('2026-04-23T10:00:00.000Z'),
},
{
id: '44444444-b26e-44fb-b9f8-4c977b28a123',
hostId: '2',
topic: 'Live community room',
mode: 'community_moderated',
status: LiveRoomStatus.Created,
createdAt: new Date('2026-04-23T11:00:00.000Z'),
},
{
id: '55555555-b26e-44fb-b9f8-4c977b28a123',
hostId: '1',
topic: 'Ended community room',
mode: 'community_moderated',
status: LiveRoomStatus.Ended,
createdAt: new Date('2026-04-23T12:00:00.000Z'),
},
]);

const scope = nock(flytingOrigin)
.post('/internal/live-rooms/counts', {
roomIds: [
'44444444-b26e-44fb-b9f8-4c977b28a123',
'33333333-b26e-44fb-b9f8-4c977b28a123',
],
})
.matchHeader('x-flyting-internal-key', flytingInternalKey)
.reply(200, {
rooms: [
{
activityStatus: 'live',
roomId: '44444444-b26e-44fb-b9f8-4c977b28a123',
participantCount: 3,
},
{
activityStatus: 'pending',
roomId: '33333333-b26e-44fb-b9f8-4c977b28a123',
participantCount: 1,
},
],
});

const res = await client.query(ACTIVE_QUERY);

expect(res.errors).toBeFalsy();
expect(res.data.activeLiveRooms).toEqual([
{
id: '44444444-b26e-44fb-b9f8-4c977b28a123',
topic: 'Live community room',
mode: 'community_moderated',
status: 'created',
activityStatus: 'live',
participantCount: 3,
host: {
id: '2',
username: 'tsahidaily',
},
},
]);
expect(scope.isDone()).toBe(true);
});

it('batches participant counts for active live rooms through the field resolver', async () => {
await saveFixtures(con, LiveRoom, [
{
Expand Down Expand Up @@ -783,6 +876,7 @@ describe('live rooms', () => {
topic: 'Live room two',
mode: 'moderated',
status: 'live',
activityStatus: 'live',
participantCount: 11,
host: {
id: '2',
Expand All @@ -794,6 +888,7 @@ describe('live rooms', () => {
topic: 'Live room one',
mode: 'moderated',
status: 'live',
activityStatus: 'live',
participantCount: 7,
host: {
id: '1',
Expand Down Expand Up @@ -874,6 +969,7 @@ describe('live rooms', () => {
topic: 'Live room without count',
mode: 'moderated',
status: 'live',
activityStatus: 'live',
participantCount: null,
host: {
id: '2',
Expand Down Expand Up @@ -1430,6 +1526,7 @@ describe('live rooms', () => {
topic: 'Readable room',
mode: 'moderated',
status: 'live',
activityStatus: 'live',
participantCount: 5,
host: {
id: '2',
Expand Down Expand Up @@ -1486,6 +1583,31 @@ describe('live rooms', () => {
expect(scope.isDone()).toBe(true);
});

it('reads legacy numeric participant count cache values', async () => {
loggedUser = '1';
const roomId = '62e45613-c9f8-4823-96cb-ebd6dcbbf4fe';

await saveFixtures(con, LiveRoom, [
{
id: roomId,
hostId: '2',
topic: 'Cached room',
mode: 'moderated',
status: LiveRoomStatus.Live,
},
]);
await ioRedisPool.execute((client) =>
client.set(liveRoomParticipantCountCacheKey(roomId), '13'),
);

const res = await client.query(GET_QUERY, {
variables: { id: roomId },
});

expect(res.errors).toBeFalsy();
expect(res.data.liveRoom.participantCount).toBe(13);
});

it('returns a live room by id for an anonymous caller', async () => {
loggedTrackingId = 'tracking-anon-1';

Expand Down Expand Up @@ -1526,6 +1648,7 @@ describe('live rooms', () => {
topic: 'Public live room',
mode: 'moderated',
status: 'live',
activityStatus: 'live',
participantCount: 4,
host: {
id: '2',
Expand Down Expand Up @@ -1563,6 +1686,7 @@ describe('live rooms', () => {
topic: 'Public scheduled lobby',
mode: 'moderated',
status: 'created',
activityStatus: 'pending',
participantCount: null,
host: {
id: '2',
Expand Down Expand Up @@ -1600,6 +1724,7 @@ describe('live rooms', () => {
topic: 'Public ended room',
mode: 'moderated',
status: 'ended',
activityStatus: null,
participantCount: null,
host: {
id: '2',
Expand Down
Loading
Loading