Skip to content

feat: apply feed v2 highlights by default#6099

Merged
idoshamun merged 1 commit into
mainfrom
eng-1575-remove-feed_v2_highlights-feature-flag-apply-treatment
May 26, 2026
Merged

feat: apply feed v2 highlights by default#6099
idoshamun merged 1 commit into
mainfrom
eng-1575-remove-feed_v2_highlights-feature-flag-apply-treatment

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented May 25, 2026

Summary

  • Removed the feed_v2_highlights feature flag definition and usage.
  • Made the feedV2 highlights treatment permanent by requesting highlight support for every FEED_V2_QUERY.
  • Simplified feedV2 supported type handling to a fixed feedV2SupportedTypes list.

Key Decisions

  • Treated FEED_V2_QUERY as the activation point instead of preserving the old flag eligibility gate.
  • Kept focused existing feed query and rendering coverage rather than adding broad layout mocks.

Verification

  • git diff --check origin/main...HEAD
  • pnpm --filter @dailydotdev/shared exec eslint src/components/MainFeedLayout.tsx src/graphql/feed.ts src/graphql/feed.spec.ts src/lib/featureManagement.ts --max-warnings 0
  • node ./scripts/typecheck-strict-changed.js
  • NODE_ENV=test pnpm --filter @dailydotdev/shared exec jest src/graphql/feed.spec.ts src/components/Feed.spec.tsx --runInBand

Linear: https://linear.app/dailydev/issue/ENG-1575/remove-feed-v2-highlights-feature-flag-apply-treatment

Closes ENG-1575


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1575-remove-feed-v2-highligh.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview May 25, 2026 3:14pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored May 25, 2026 3:14pm

Request Review

@idoshamun idoshamun merged commit 6070c97 into main May 26, 2026
11 checks passed
@idoshamun idoshamun deleted the eng-1575-remove-feed_v2_highlights-feature-flag-apply-treatment branch May 26, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants