Bind Action evaluation to the workflow PR head SHA - #59
Open
daichunghy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This binds the Action's authenticated snapshot to the exact
pull_request.head.shathat triggered the workflow and makes the selected commit visible in the Check Run output.The change follows the technical feedback in Discussion #29.
Linked Issues
Changes Classification
Review-Readiness Checklist
npm run verify(lint, types, unit tests, security tests, fixtures, CLI smoke).anytypes introduced in production code.What changed
expectedHeadShaassertion to the GitHub identity request.GITHUB_TARGET_CHANGEDbefore evaluation when the live PR head has advanced past the workflow event.testedSha,headSha,baseSha, target kind and binding state in the summary and Check Run text.target-kind,tested-shaandhead-shaAction outputs.head_shadiffers from the receipt'stestedSha.checks:write, so its PR comment is context, not required-check evidence.Evidence
npm run verify— pass: 110 main tests, 14 security tests, 33 GitHub integration tests, 6 CLI smoke tests, clean-room bundle and consumer fixture.Boundary
This PR does not claim an external QAOnFire installation or end-to-end success. QAOnFire's current public App permissions do not expose a Check Run path; an authorized maintainer run is still required to validate the workflow in their repository.