Add support for CREATE SCHEMA - #99
Open
ateirney-nz wants to merge 1 commit into
Open
Conversation
Model CREATE SCHEMA in the diff engine: create schemas before any object that may live inside them and drop them after their contents. Add an --ignore-create-schema flag (and IgnoreCreateSchema option) for parity with the other ignore flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
CREATE SCHEMA(named schemas) to the diff engine so that schema definitions using named schemas can be exported, diffed, and applied.Changes
CREATE SCHEMAin the diff engine (NewDatabase): collect*ast.CreateSchemastatements into a newschemasset and aSchemawrapper type, instead of erroring on the unrecognised statement.GenerateDDL):CREATE SCHEMAbefore any tables — so the schema exists before objects are created inside it.DROP SCHEMAlast — after every object inside them has been dropped.--ignore-create-schemaflag (andIgnoreCreateSchemaoption) added toapply,create,diff, andexport, for parity with the existing--ignore-*flags.Ordering
Verified that schema-qualified objects diff and order correctly in both directions:
CREATE SCHEMA→ table → index → viewDROP SCHEMATests
TestParseDDL: ignore-create-schema case.TestDiff: create/drop schema, no-op when unchanged, and ordering relative to schema-qualified tables, indexes, and views.go build ./...,go vet ./..., andgo test ./...all pass.